Fix building bwc versions#40361
Merged
AthenaEryma merged 1 commit intoelastic:masterfrom Mar 22, 2019
Merged
Conversation
we have to account for openjdk when figuring out what java version to use for building bwc versions.
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@elasticmachine test this please |
1 similar comment
Contributor
Author
|
@elasticmachine test this please |
pgomulka
approved these changes
Mar 22, 2019
Contributor
pgomulka
left a comment
There was a problem hiding this comment.
LGTM once the CI is green
| getJavaHome(it, Integer.parseInt( | ||
| lines | ||
| .findAll({ it.startsWith("ES_BUILD_JAVA=java") }) | ||
| .findAll({ it.startsWith("ES_BUILD_JAVA=")}) |
Contributor
There was a problem hiding this comment.
should the ES_RUNTIME_JAVA be updated too?
Should we also update the .ci/java-versions.properties ?
Contributor
There was a problem hiding this comment.
also should we change this line below?
.collect({ it.replace("ES_BUILD_JAVA=java", "").trim() })
pgomulka
reviewed
Mar 22, 2019
Contributor
pgomulka
left a comment
There was a problem hiding this comment.
actually not sure if this will pass - still failing for me locally
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
AthenaEryma
pushed a commit
that referenced
this pull request
Mar 22, 2019
Account for openjdk when figuring out what java version to use for building bwc versions.
AthenaEryma
pushed a commit
that referenced
this pull request
Mar 22, 2019
Account for openjdk when figuring out what java version to use for building bwc versions.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2019
…-stop-time * elastic/master: Muting test testExtractIndexCheckpointsInconsistentGlobalCheckpoints (elastic#40371) DOC: polish client docs Fix building bwc versions (elastic#40361)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2019
* elastic/master: [DOCS] Adds notable highlights tags (elastic#40330) [ML] making test more determinate (elastic#40374) [ML] adds support for non-numeric mapped types (elastic#40220) Move outbound message handling to OutboundHandler (elastic#40336) Add implicit this for class binding in Painless (elastic#40285) Muting test testExtractIndexCheckpointsInconsistentGlobalCheckpoints (elastic#40371) DOC: polish client docs Fix building bwc versions (elastic#40361)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we have to account for openjdk when figuring out what java version to
use for building bwc versions.