Change HLRC CCR response tests to use AbstractResponseTestCase base class#40257
Merged
martijnvg merged 1 commit intoelastic:masterfrom Apr 8, 2019
Merged
Conversation
…lass. This way the response classes are tested in a more realistic setting. Relates to elastic#39745
Collaborator
|
Pinging @elastic/es-core-features |
hub-cap
approved these changes
Apr 5, 2019
Contributor
hub-cap
left a comment
There was a problem hiding this comment.
This is much nicer, tyvm @martijnvg
| builder.endObject(); | ||
| } | ||
| builder.endObject(); | ||
| equalTo(expectedShardFollowStats.timeSinceLastReadMillis())); |
Contributor
There was a problem hiding this comment.
lol @ this diff, thanks github :P
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Apr 8, 2019
…eTestCase base class. (elastic#40257)"" This reverts commit df91237.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 9, 2019
…forced-unsafe-publication * elastic/master: Improve Watcher test framework resiliency (elastic#40658) Fix order of request body search parameter names in documentation (elastic#40777) Node repurpose tool docs (elastic#40525) [Docs] Delete explanation for completion suggester default analyzer choice (elastic#36720) Revert "Revert "Change HLRC CCR response tests to use AbstractResponseTestCase base class. (elastic#40257)"" (elastic#40971) Short-circuit rebalancing when disabled (elastic#40966)
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…lass. (elastic#40257) This way the response classes are tested in a more realistic setting. Relates to elastic#39745
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…e base class. (elastic#40257)" This reverts commit 675bf3c.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…eTestCase base class. (elastic#40257)"" (elastic#40971) This reverts commit df91237.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way the response classes are tested in a more realistic setting.
Note this change also adds a test dependency on xpack core module.
Relates to #39745