Do not swallow exceptions in TimedRunnable#39856
Merged
ywelsch merged 3 commits intoelastic:masterfrom Mar 11, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
henningandersen
approved these changes
Mar 11, 2019
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
Added one small nit. Thanks @ywelsch
server/src/test/java/org/elasticsearch/common/util/concurrent/TimedRunnableTests.java
Outdated
Show resolved
Hide resolved
ywelsch
added a commit
that referenced
this pull request
Mar 11, 2019
Executors of type fixed_auto_queue_size (i.e. search / search_throttled) wrap runnables into TimedRunnable, which is an AbstractRunnable. This is dangerous as it might silently swallow exceptions, and possibly miss calling a response listener. While this has not triggered any failures in the tests I have run so far, it might help uncover future problems. Follow-up to #36137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executors of type
fixed_auto_queue_size(i.e. search / search_throttled) wrap runnables intoTimedRunnable, which is anAbstractRunnable. This is dangerous as it might silently swallow exceptions, and possibly miss calling a response listener. While this has not triggered any failures in the tests I have run so far, it might help uncover future problems.Follow-up to #36137.