Add option to force load term dict into memory#39741
Merged
s1monw merged 3 commits intoelastic:masterfrom Mar 6, 2019
Merged
Conversation
Lucene added an optimization to leave the term dictionary on disk for non-id like fields. This change happend very late in the release processes such that it's better to have an escape hatch if certain usecases are hurt by this optimization. This setting might be removed in the future if it turns out to be unnecessary.
Collaborator
|
Pinging @elastic/es-distributed |
jpountz
suggested changes
Mar 6, 2019
Contributor
jpountz
left a comment
There was a problem hiding this comment.
I think we need to wrap slices as well because of compound files.
jpountz
approved these changes
Mar 6, 2019
s1monw
added a commit
that referenced
this pull request
Mar 6, 2019
Lucene added an optimization to leave the term dictionary on disk for non-id like fields. This change happened very late in the release processes such that it's better to have an escape hatch if certain use-cases are hurt by this optimization. This setting might be removed in the future if it turns out to be unnecessary.
s1monw
added a commit
that referenced
this pull request
Mar 6, 2019
Lucene added an optimization to leave the term dictionary on disk for non-id like fields. This change happened very late in the release processes such that it's better to have an escape hatch if certain use-cases are hurt by this optimization. This setting might be removed in the future if it turns out to be unnecessary.
mikemccand
reviewed
Mar 6, 2019
| /** | ||
| * see {@link #FORCE_RAM_TERM_DICT} for details | ||
| */ | ||
| private static final class DeoptimizingIndexInput extends IndexInput { |
Contributor
There was a problem hiding this comment.
Clever!
We are trying to add per-field control here: https://issues.apache.org/jira/browse/LUCENE-8671
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 5, 2019
This temporary setting was introduced in elastic#39741 but has had no effect since it was deprecated in elastic#42838. This commit removes this setting.
DaveCTurner
added a commit
that referenced
this pull request
Nov 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lucene added an optimization to leave the term dictionary on disk
for non-id like fields. This change happened very late in the release
processes such that it's better to have an escape hatch if certain
usecases are hurt by this optimization. This setting might be
removed in the future if it turns out to be unnecessary.