[Data-Frame] make the config be strictly parsed on _preview#39713
Merged
benwtrent merged 5 commits intoelastic:masterfrom Mar 9, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core |
|
may I play devils advocate? If we missed this in the 1st place it means we lack a test. |
Member
Author
|
@elasticmachine |
Member
Author
|
run elasticsearch-ci/bwc |
Member
Author
|
run elasticsearch-ci/bwc |
2 similar comments
Member
Author
|
run elasticsearch-ci/bwc |
Member
Author
|
run elasticsearch-ci/bwc |
Member
Author
|
run elasticsearch-ci/bwc |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Mar 9, 2019
…39713) * [Data-Frame] make the config be strictly parsed on _preview * adding test to verify strictly parsing * adjusting test after master merge
benwtrent
added a commit
that referenced
this pull request
Mar 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple change, it should have been strictly parsed from the get go....