Minor Cleanups in QueryPhase#39680
Merged
original-brownbear merged 1 commit intoelastic:masterfrom Mar 5, 2019
original-brownbear:simple-cleanup-query-phase
Merged
Minor Cleanups in QueryPhase#39680original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:simple-cleanup-query-phase
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:simple-cleanup-query-phase
Conversation
* Soften redundant cast to allow use of `DeterministicTaskQueue` in this class for #39504 * Remove two redundant variables and lower visibility in two possible spots * Make field `final`
Collaborator
|
Pinging @elastic/es-search |
Contributor
Author
|
@jimczi thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeterministicTaskQueuein this class for the new tests incoming in More Snapshot Resiliency Testing #39504finalI only really needed the first change as a dependency for #39504 but I figured I'd clean up the other spots while I'm at it :)