Add debug log for flush for IndicesRequestCacheIT#39475
Merged
mayya-sharipova merged 2 commits intoelastic:masterfrom Feb 28, 2019
Merged
Add debug log for flush for IndicesRequestCacheIT#39475mayya-sharipova merged 2 commits intoelastic:masterfrom
mayya-sharipova merged 2 commits intoelastic:masterfrom
Conversation
Add debug log when index is flushed to investigate a failure in IndicesRequestCacheIT "DEBUG" level is used as "TRACES" produces too much output irrelevant for this issue Relates to elastic#32827
Collaborator
|
Pinging @elastic/es-search |
colings86
approved these changes
Feb 28, 2019
Contributor
colings86
left a comment
There was a problem hiding this comment.
I left a couple of suggestions in case we can get extra information but I'll leave them up to you as I'm not sure about the risk that the extra logging might cause the test failure to not reproduce due to changing the timing so there is probably an argument for being careful how much we do at one time.
| logger.trace("finished commit for flush"); | ||
|
|
||
| // a temporary debugging to investigate test failure - issue#32827. Remove when the issue is resolved | ||
| logger.debug("new commit on flush"); |
Contributor
There was a problem hiding this comment.
It might help to know which of the conditions (indexWriter.hasUncommittedChanges(), force or shouldPeriodicallyFlush()) triggered this flush to help us work out what is causing this?
| import static org.hamcrest.Matchers.greaterThan; | ||
|
|
||
| @TestLogging(value = "org.elasticsearch.indices.IndicesRequestCache:TRACE") | ||
| @TestLogging(value = "org.elasticsearch.indices.IndicesRequestCache:TRACE,org.elasticsearch.index.engine.Engine:DEBUG") |
Contributor
There was a problem hiding this comment.
I wonder if we should actually enable trace logging on the Engine for this test? My thought here is with trace logging we might also be able to see if the unexpected flush is waiting for an ongoing flush or if its acquired immediately?
Contributor
Author
|
@cbuescher, @colings86 thanks for the review |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
mayya-sharipova
added a commit
that referenced
this pull request
Mar 1, 2019
Add debug log when index is flushed to investigate a failure in IndicesRequestCacheIT "DEBUG" level is used as "TRACE" produces too much output irrelevant for this issue Relates to #32827
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Sep 17, 2020
In the context of of a recurring test failure tracked by elastic#32827, we added trace logging and an extra cache key renderer argument to IndicesRequestCache#getOrCompute (see elastic#39475 and elastic#34180). We addressed the issue with elastic#54071, but the extra argument was left behind, with a NORELEASE comment saying it should be removed. With this commit, we remove the extra cache key rendered argument and the corresponding log lines which are not so useful without it. Closes elastic#55837
javanna
added a commit
that referenced
this pull request
Sep 18, 2020
In the context of of a recurring test failure tracked by #32827, we added trace logging and an extra cache key renderer argument to IndicesRequestCache#getOrCompute (see #39475 and #34180). We addressed the issue with #54071, but the extra argument was left behind, with a NORELEASE comment saying it should be removed. With this commit, we remove the extra cache key rendered argument and the corresponding log lines which are not so useful without it. Closes #55837
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Sep 18, 2020
…62534) In the context of of a recurring test failure tracked by elastic#32827, we added trace logging and an extra cache key renderer argument to IndicesRequestCache#getOrCompute (see elastic#39475 and elastic#34180). We addressed the issue with elastic#54071, but the extra argument was left behind, with a NORELEASE comment saying it should be removed. With this commit, we remove the extra cache key rendered argument and the corresponding log lines which are not so useful without it. Closes elastic#55837
javanna
added a commit
that referenced
this pull request
Sep 18, 2020
In the context of of a recurring test failure tracked by #32827, we added trace logging and an extra cache key renderer argument to IndicesRequestCache#getOrCompute (see #39475 and #34180). We addressed the issue with #54071, but the extra argument was left behind, with a NORELEASE comment saying it should be removed. With this commit, we remove the extra cache key rendered argument and the corresponding log lines which are not so useful without it. Closes #55837
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add debug log when index is flushed to investigate a failure
in IndicesRequestCacheIT
"DEBUG" level is used as "TRACES" produces too much output irrelevant for this
issue
Relates to #32827