Fix DissectParserTests expecting unique keys#39262
Merged
albertzaharovits merged 2 commits intoelastic:masterfrom Feb 22, 2019
Merged
Fix DissectParserTests expecting unique keys#39262albertzaharovits merged 2 commits intoelastic:masterfrom
albertzaharovits merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-features |
jakelandis
reviewed
Feb 21, 2019
| for (int i = 0; i < results.size(); i++) { | ||
| final String key = expectedKeys.get(i); | ||
| assertThat(results.get(key), Matchers.equalTo(expectedValues.get(i))); | ||
| } |
Contributor
There was a problem hiding this comment.
This slightly changes the assertion by no longer explicitly asserting that that the keys match. Is this change needed to fix the test(s) ?
Contributor
Author
There was a problem hiding this comment.
It does check that the keys match, given that the keys are unique in the expectedKeys array. The original check was flawed because it was sorting parallel arrays independently.
albertzaharovits
added a commit
that referenced
this pull request
Feb 22, 2019
Fixes a bug in DissectParserTests where the tests expected dissect keys to be unique but were not. Closes #39244
albertzaharovits
added a commit
that referenced
this pull request
Feb 22, 2019
Fixes a bug in DissectParserTests where the tests expected dissect keys to be unique but were not. Closes #39244
albertzaharovits
added a commit
that referenced
this pull request
Feb 22, 2019
Fixes a bug in DissectParserTests where the tests expected dissect keys to be unique but were not. Closes #39244
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
Fixes a bug in DissectParserTests where the tests expected dissect keys to be unique but were not. Closes elastic#39244
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
Fixes a bug in DissectParserTests where the tests expected dissect keys to be unique but were not. Closes elastic#39244
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in DissectParserTests where the tests expected dissect keys to be unique but were not.
Closes #39244