Enable smoke-test-watcher with logging#39169
Merged
tvernum merged 1 commit intoelastic:masterfrom Feb 20, 2019
Merged
Conversation
SmokeTestWatcherTestSuiteIT.testMonitorClusterHealth has failed a few times with various causes (not all of which we have logs for). This change enables the test again. 1. The fix from elastic#39092 should resolve any issues in assertWatchCount 2. In at least 1 case, getWatchHistoryEntry failed due to a ResponseException, which is not caught by assertBusy. This commit catches those and calls "fail" so that assertBusy will sleep and retry 3. Additional logging has been included to help diagnose any other failures causes.
Collaborator
|
Pinging @elastic/es-core-features |
jakelandis
approved these changes
Feb 20, 2019
Contributor
jakelandis
left a comment
There was a problem hiding this comment.
LGTM , thanks for the additional logging and error handling !
Contributor
Author
|
I'm going to hold off on the backport of this until it's been through a few days of CI runs. |
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
SmokeTestWatcherTestSuiteIT.testMonitorClusterHealth has failed a few times with various causes (not all of which we have logs for). This change enables the test again. 1. The fix from elastic#39092 should resolve any issues in assertWatchCount 2. In at least 1 case, getWatchHistoryEntry failed due to a ResponseException, which is not caught by assertBusy. This commit catches those and calls "fail" so that assertBusy will sleep and retry 3. Additional logging has been included to help diagnose any other failures causes.
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
SmokeTestWatcherTestSuiteIT.testMonitorClusterHealth has failed a few times with various causes (not all of which we have logs for). This change enables the test again. 1. The fix from elastic#39092 should resolve any issues in assertWatchCount 2. In at least 1 case, getWatchHistoryEntry failed due to a ResponseException, which is not caught by assertBusy. This commit catches those and calls "fail" so that assertBusy will sleep and retry 3. Additional logging has been included to help diagnose any other failures causes.
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Jun 29, 2019
…history Catch exceptions and fail (which allows the assertBusy to retry) if an error happens from the search against .watcher-history. Related: elastic#42409 Related: elastic#39169
jakelandis
added a commit
that referenced
this pull request
Jul 1, 2019
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Jul 1, 2019
…43781) Retry if failures searching .watcher-history Catch exceptions and fail (which allows the assertBusy to retry) if an error happens from the search against .watcher-history. Related: elastic#42409 Related: elastic#39169
Contributor
|
@tvernum I'm assuming there is nothing left to backport and removed the backport pending label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SmokeTestWatcherTestSuiteIT.testMonitorClusterHealth has failed a few
times with various causes (not all of which we have logs for).
This change enables the test again.
ResponseException, which is not caught by assertBusy.
This commit catches those and calls "fail" so that assertBusy will
sleep and retry
failures causes.
Relates: #32299