Add support for ccr follow info api to HLRC.#39115
Merged
martijnvg merged 3 commits intoelastic:masterfrom Feb 20, 2019
Merged
Conversation
This API was introduces after elastic#33824 was closed.
Collaborator
|
Pinging @elastic/es-core-features |
hub-cap
approved these changes
Feb 19, 2019
Contributor
hub-cap
left a comment
There was a problem hiding this comment.
super easy to read. Youve done this before, i can tell ;)
Also, I just noticed (after all these reviews heh) that there is no CCRRequestConvertersTests class... Could you add that in a new PR or put up a GH ticket so someone can do it?
| PARSER.declareObjectArray(ConstructingObjectParser.constructorArg(), FollowerInfo.PARSER, FOLLOWER_INDICES_FIELD); | ||
| } | ||
|
|
||
|
|
| Collections.emptySet() | ||
| ); | ||
| } | ||
|
|
Member
Author
👍I will open a follow up pr for this. |
Member
Author
|
@elasticmachine run elasticsearch-ci/bwc |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 20, 2019
* master: Mute failing CCR retention lease unfollow test Add support for ccr follow info api to HLRC. (elastic#39115) Do not create the missing index when invoking getRole (elastic#39039) Relax history check in ShardFollowTaskReplicationTests (elastic#39162) Add retention leases replication tests (elastic#38857) Edits to text in Phrase Suggester doc (elastic#38966) Edits to text in API Conventions docs (elastic#39001)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 20, 2019
* master: Mute failing CCR retention lease unfollow test Add support for ccr follow info api to HLRC. (elastic#39115) Do not create the missing index when invoking getRole (elastic#39039) Relax history check in ShardFollowTaskReplicationTests (elastic#39162) Add retention leases replication tests (elastic#38857) Edits to text in Phrase Suggester doc (elastic#38966) Edits to text in API Conventions docs (elastic#39001)
martijnvg
added a commit
that referenced
this pull request
Feb 20, 2019
This API was introduces after #33824 was closed.
martijnvg
added a commit
that referenced
this pull request
Feb 20, 2019
This API was introduces after #33824 was closed.
martijnvg
added a commit
that referenced
this pull request
Feb 20, 2019
This API was introduces after #33824 was closed.
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
This API was introduces after elastic#33824 was closed.
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
This API was introduces after elastic#33824 was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API was recently introduced via #37408, but the hlrc side is still missing.
Relates to #33824