Remove nGram and edgeNGram token filter names (#38911)#39070
Merged
cbuescher merged 4 commits intoelastic:7.0from Feb 21, 2019
Merged
Remove nGram and edgeNGram token filter names (#38911)#39070cbuescher merged 4 commits intoelastic:7.0from
nGram and edgeNGram token filter names (#38911)#39070cbuescher merged 4 commits intoelastic:7.0from
Conversation
In elastic#30209 we deprecated the camel case `nGram` filter name in favour of `ngram` and did the same for `edgeNGram` and `edge_ngram`. Using these names has been deprecated since 6.4 and is issuing deprecation warnings since then. I think we can remove these filters in 8.0. In a backport of this PR I would change what was a dreprecation warning from 6.4. to an error starting with new indices created in 7.0.
Collaborator
|
Pinging @elastic/es-search |
Member
Author
jimczi
reviewed
Feb 18, 2019
Contributor
jimczi
left a comment
There was a problem hiding this comment.
Thanks @cbuescher , I left one question.
...es/analysis-common/src/main/java/org/elasticsearch/analysis/common/CommonAnalysisPlugin.java
Outdated
Show resolved
Hide resolved
...es/analysis-common/src/main/java/org/elasticsearch/analysis/common/CommonAnalysisPlugin.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@jimczi thanks, I pushed a commit adressing your comments |
jimczi
approved these changes
Feb 21, 2019
Contributor
jimczi
left a comment
There was a problem hiding this comment.
I left minor comments but feel free to merge without another review.
...es/analysis-common/src/main/java/org/elasticsearch/analysis/common/CommonAnalysisPlugin.java
Outdated
Show resolved
Hide resolved
...es/analysis-common/src/main/java/org/elasticsearch/analysis/common/CommonAnalysisPlugin.java
Outdated
Show resolved
Hide resolved
cbuescher
pushed a commit
that referenced
this pull request
Feb 21, 2019
In #30209 we deprecated the camel case `nGram` filter name in favour of `ngram` and did the same for `edgeNGram` and `edge_ngram` and we are removing those names in 8.0. This change disallows using the deprecated names for new indices created in 7.0 by throwing an error if these filters are used. Relates to #38911
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #30209 we deprecated the camel case
nGramtoken filter in favour ofngramanddeprecated
edgeNGramin favour ofedge_ngram. Using these names has been deprecatedsince 6.4, issuing deprecation warnings on new indices since then. In addition to remove the filter
in 8.0 completely (see ##38911) we should not allow index creation using these filter names
starting with 8.0. This PR adds throwing an IAE when this filter name is used in indices created from
7.0 on.