Skip to content

Adjust BWC version for token/API key service#38917

Merged
jasontedor merged 2 commits intoelastic:masterfrom
jasontedor:bwc-enabled-status
Feb 14, 2019
Merged

Adjust BWC version for token/API key service#38917
jasontedor merged 2 commits intoelastic:masterfrom
jasontedor:bwc-enabled-status

Conversation

@jasontedor
Copy link
Copy Markdown
Member

This commit adjusts the BWC version for the token/API key service enabled status flag that was added to security feature set usage.

Relates #38687

This commit adjusts the BWC version for the token/API key service
enabled status flag that was added to security feature set usage.
@jasontedor jasontedor added >non-issue :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.0.0 labels Feb 14, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-security

@jasontedor jasontedor requested a review from jaymode February 14, 2019 18:37
Copy link
Copy Markdown
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the writing of the object

jaymode added a commit to jaymode/elasticsearch that referenced this pull request Feb 14, 2019
This change makes the writing of new usage data conditional based on
the version that is being written to. A test has also been added to
ensure serialization works as expected to an older version.

Relates elastic#38687, elastic#38917
@jasontedor jasontedor merged commit b76a083 into elastic:master Feb 14, 2019
@jasontedor jasontedor deleted the bwc-enabled-status branch February 14, 2019 21:01
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 14, 2019
* master:
  Adjust BWC version for token/API key service (elastic#38917)
  [Monitoring] Remove `include_type_name` parameter from GET _template request (elastic#38818)
  Revert "[test] disable packaging tests for suse boxes" (elastic#38864)
jaymode added a commit that referenced this pull request Feb 14, 2019
This change makes the writing of new usage data conditional based on
the version that is being written to. A test has also been added to
ensure serialization works as expected to an older version.

Relates #38687, #38917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants