SQL: Implement :: cast operator#38774
Merged
matriv merged 2 commits intoelastic:masterfrom Feb 12, 2019
Merged
Conversation
`<expression>::<dataType>` is a simplified altenative syntax to `CAST(<expression> AS <dataType> which exists in PostgreSQL and provides an improved user experience and possibly more compact SQL queries. Fixes: elastic#38717
Collaborator
|
Pinging @elastic/es-search |
costin
approved these changes
Feb 12, 2019
| | '(' expression ')' #parenthesizedExpression | ||
| ; | ||
|
|
||
| builtinDateTimeFunction |
Contributor
Author
There was a problem hiding this comment.
just to have the cast/convert declarations next to each other.
|
|
||
| public void testCastOperatorWithInvalidDataType() { | ||
| ParsingException ex = expectThrows(ParsingException.class, () -> parser.createExpression("-1::INVALID")); | ||
| assertEquals("line 1:6: Does not recognize type invalid", ex.getMessage()); |
Member
There was a problem hiding this comment.
The message needs improving - use "Does not recognize type [{}]", type.sourceText() - to preserve the original declaration inside visitPrimitiveDataType
matriv
added a commit
that referenced
this pull request
Feb 12, 2019
`<expression>::<dataType>` is a simplified altenative syntax to `CAST(<expression> AS <dataType> which exists in PostgreSQL and provides an improved user experience and possibly more compact SQL queries. Fixes: #38717
Contributor
Author
|
Backported to |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 13, 2019
* master: Remove _type term filters from cluster alert watches (elastic#38819) Adjust log and unmute testFailOverOnFollower (elastic#38762) Fix line separators in JSON logging tests (elastic#38771) Fix synchronization in LocalCheckpointTracker#contains (elastic#38755) muted test Remove TLSv1.2 pinning in ssl reload tests (elastic#38651) Don't fail init script if `/proc/.../max_map_count` absent (elastic#35933) Format Watcher.status.lastChecked and lastMetCondition (elastic#38626) SQL: Implement `::` cast operator (elastic#38774) Ignore failing test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<expression>::<dataType>is a simplified altenative syntax to`CAST( AS which exists in PostgreSQL and
provides an improved user experience and possibly more compact
SQL queries.
Fixes: #38717