Enable removal of retention leases#38751
Merged
jasontedor merged 1 commit intoelastic:masterfrom Feb 12, 2019
Merged
Conversation
This commit introduces the ability to remove retention leases. Explicit removal will be needed to manage retention leases used to increase the likelihood of operation-based recoveries syncing, and for consumers such as ILM.
Collaborator
|
Pinging @elastic/es-distributed |
24 tasks
jasontedor
commented
Feb 11, 2019
| synchronized (this) { | ||
| assert primaryMode; | ||
| if (retentionLeases.contains(id) == false) { | ||
| throw new IllegalArgumentException("retention lease with ID [" + id + "] does not exist"); |
Member
Author
There was a problem hiding this comment.
This will change to a RetentionLeaseNotFoundException with the integration of #38754.
jasontedor
added a commit
that referenced
this pull request
Feb 12, 2019
This commit introduces the ability to remove retention leases. Explicit removal will be needed to manage retention leases used to increase the likelihood of operation-based recoveries syncing, and for consumers such as ILM.
jasontedor
added a commit
that referenced
this pull request
Feb 12, 2019
This commit introduces the ability to remove retention leases. Explicit removal will be needed to manage retention leases used to increase the likelihood of operation-based recoveries syncing, and for consumers such as ILM.
jasontedor
added a commit
that referenced
this pull request
Feb 12, 2019
This commit introduces the ability to remove retention leases. Explicit removal will be needed to manage retention leases used to increase the likelihood of operation-based recoveries syncing, and for consumers such as ILM.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 12, 2019
* master: Enable removal of retention leases (elastic#38751) Make the 'get templates' types deprecation message consistent. (elastic#38533) Copy retention leases when trim unsafe commits (elastic#37995) Fix the version check for LegacyGeoShapeFieldMapper (elastic#38547)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 12, 2019
* master: Enable removal of retention leases (elastic#38751) Make the 'get templates' types deprecation message consistent. (elastic#38533) Copy retention leases when trim unsafe commits (elastic#37995) Fix the version check for LegacyGeoShapeFieldMapper (elastic#38547)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to remove retention leases. Explicit removal will be needed to manage retention leases used to increase the likelihood of operation-based recoveries syncing, and for consumers such as ILM.
Relates #37165