IndexShard state should also be started.#38630
Conversation
|
Pinging @elastic/es-distributed |
|
Note this change should be backported to 7.x, 7.0 and 6.7 branches. The |
dnhatn
left a comment
There was a problem hiding this comment.
Thanks @martijnvg. I left a comment.
| .indexServiceSafe(shardRouting.index()).getShard(shardRouting.id()); | ||
| if (indexShard.state() != IndexShardState.STARTED) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I think we should catch "AlreadyClosedException" when calling IndexShardTestCase.getDocIdAndSeqNos(indexShard) instead?
|
@dnhatn I've updated the PR. |
|
@martijnvg Does this need to be backported to 6.7? |
|
@jasontedor Yes, and it was backported: 232d2e0 |
|
I just forgot to update the version labels here. |
|
Okay, I think that I see what happened. The test is still marked as awaits fix in the 6.7 and 7.0 branch. I think that is the case because they were never marked as awaits fix in master, so that when you developed the fix you didn't have to remove the awaits fix, and hence no removal of the awaits fix when you cherry picked back. |
Fixes #38617 (the test also failed in 8.0 / 7.x, but happens less likely)