Remove copy_settings flag from resize operations#38553
Closed
jkakavas wants to merge 1 commit intoelastic:masterfrom
Closed
Remove copy_settings flag from resize operations#38553jkakavas wants to merge 1 commit intoelastic:masterfrom
jkakavas wants to merge 1 commit intoelastic:masterfrom
Conversation
This commit removes the `copy_settings` flag for shrink and split operations. The flag was introduced in elastic#30255 and the default value from now onwards is for the settings to be copied.
Collaborator
|
Pinging @elastic/es-core-features |
martijnvg
approved these changes
Feb 7, 2019
Member
martijnvg
left a comment
There was a problem hiding this comment.
LGTM, but would be good to have another set of eyes checking this change.
tlrx
approved these changes
Feb 7, 2019
Member
tlrx
left a comment
There was a problem hiding this comment.
LGTM - as a follow up we should also remove the copy settings from the ResizeRequest object
Contributor
albertzaharovits
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 7, 2019
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jul 9, 2021
previously removed in elastic#38553, deprecated in 7.x and defaulted to true. With rest api compatibility value is ignored and warning is emitted relates elastic#51816
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
copy_settingsflag for shrink and splitoperations. The flag was introduced in
#30255 and the default
value from now on is for the settings to be copied.