Fix testReplicaIgnoresOlderRetentionLeasesVersion#38246
Merged
dnhatn merged 1 commit intoelastic:masterfrom Feb 2, 2019
Merged
Fix testReplicaIgnoresOlderRetentionLeasesVersion#38246dnhatn merged 1 commit intoelastic:masterfrom
dnhatn merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
Member
Author
|
@jasontedor I am wondering if we should add a new assertion to ensure that if the term and version are the same, then the leases must also be the same (like the existing assertion that we have in Translog https://github.com/elastic/elasticsearch/blob/master/server/src/main/java/org/elasticsearch/index/translog/TranslogWriter.java#L215)? |
Member
Author
|
Thanks @jasontedor. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 2, 2019
If the innerLength is 0, the version won't be increased; then there will be two RetentionLeases with the same term and version, but their leases are different. Relates elastic#37951 Closes elastic#38245
dnhatn
added a commit
that referenced
this pull request
Feb 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the innerLength is 0, the version won't be increased; then there will
be two RetentionLeases with the same term and version, but their leases
are different.
Relates #37951
Closes #38245