Disable dynamic mapping update in testTransportBulkTasks#38073
Merged
dnhatn merged 1 commit intoelastic:masterfrom Jan 31, 2019
Merged
Disable dynamic mapping update in testTransportBulkTasks#38073dnhatn merged 1 commit intoelastic:masterfrom
dnhatn merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
original-brownbear
approved these changes
Jan 31, 2019
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM (but maybe let @ywelsch double check :))
Member
Author
|
@original-brownbear @ywelsch thanks for reviewing. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 1, 2019
If a replica does not have a right mapping yet, we will retry the index request on that replica; then the actual tasks is higher than the expected tasks. Since elastic#31140 this happens more frequently for we no longer require acking on the dynamic mapping of index requests. Relates elastic#31140 Closes elastic#37893
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a replica does not have a right mapping yet, we will retry the index request on that replica; then the actual tasks is higher than the expected tasks. Since #31140 this happens more frequently for we no longer require acking on the dynamic mapping of index requests.
Relates #31140
Closes #37893