Disable dynamic mapping in testSimpleGetFieldMappingsWithDefaults#38045
Merged
dnhatn merged 4 commits intoelastic:masterfrom Feb 1, 2019
Merged
Disable dynamic mapping in testSimpleGetFieldMappingsWithDefaults#38045dnhatn merged 4 commits intoelastic:masterfrom
dnhatn merged 4 commits intoelastic:masterfrom
Conversation
We need to await busily for the mapping in this test because we no longer require acking on the dynamic mapping of an index request. Relates elastic#31140 Closes elastic#37928
Collaborator
|
Pinging @elastic/es-search |
javanna
reviewed
Jan 31, 2019
| assertNotNull(response.fieldMappings("test", "type", "obj.subfield")); | ||
| assertThat((Map<String, Object>) response.fieldMappings("test", "type", "obj.subfield").sourceAsMap().get("subfield"), | ||
| hasEntry("type", "keyword")); | ||
| }); |
Contributor
There was a problem hiding this comment.
I was wondering if the whole code block needs to be in the assertBusy ?
Member
Author
There was a problem hiding this comment.
No, we only need to ensure that the mapping is ready. Anyway, I replaced the dynamic mapping update with a put-mapping request. Thanks for looking @javanna.
Member
Author
|
run elasticsearch-ci/default-distro |
jtibshirani
approved these changes
Jan 31, 2019
Contributor
jtibshirani
left a comment
There was a problem hiding this comment.
This looks good to me!
Member
Author
|
Thanks @javanna and @jtibshirani. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 1, 2019
…astic#38045) Since elastic#31140 we no longer require acking on the dynamic mapping of index requests. Thus, a returned mapping from a get mapping request does not necessarily contain the dynamic updates from the index request. This commit replaces the dynamic mapping update with a manual put mapping. Relates elastic#31140 Closes elastic#37928
dnhatn
added a commit
that referenced
this pull request
Feb 1, 2019
Since #31140 we no longer require acking on the dynamic mapping of index requests. Thus, a returned mapping from a get mapping request does not necessarily contain the dynamic updates from the index request. This commit replaces the dynamic mapping update with a manual put mapping. Relates #31140 Closes #37928
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #31140 we no longer require acking on the dynamic mapping of index requests. Thus, a returned mapping from a get mapping request does not necessarily contain the dynamic updates from the index request. This commit replaces the dynamic mapping update with a manual put mapping.
Relates #31140
Closes #37928