Remove deprecated Plugin#onModule extension points#37866
Merged
cbuescher merged 3 commits intoelastic:masterfrom Jan 30, 2019
Merged
Remove deprecated Plugin#onModule extension points#37866cbuescher merged 3 commits intoelastic:masterfrom
cbuescher merged 3 commits intoelastic:masterfrom
Conversation
Removes some guice index level extension point marked as @deprecated since at least 6.0. They served as a signpost for plugin authors upgrading from 2.x but this shouldn't be relevant in 7.0 anymore.
Collaborator
|
Pinging @elastic/es-core-infra |
danielmitterdorfer
approved these changes
Jan 29, 2019
Member
danielmitterdorfer
left a comment
There was a problem hiding this comment.
Thanks for doing this cleanup! LGTM. Feel free to merge once Jenkins is happy.
Member
Author
|
@elasticmachine test this please |
jasontedor
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 30, 2019
* master: Expose retention leases in shard stats (elastic#37991) Make primary terms fields private in index shard (elastic#38036) ML: Add reason field in JobTaskState (elastic#38029) Log flush_stats and commit_stats in testMaybeFlush HLRC: Fix strict setting exception handling (elastic#37247) Test: Enable strict deprecation on all tests (elastic#36558) Removes typed calls from YAML REST tests (elastic#37611) Switch default time format for ingest from Joda to Java for v7 (elastic#37934) Remove deprecated Plugin#onModule extension points (elastic#37866) Geo: Fix Empty Geometry Collection Handling (elastic#37978)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes some guice index level extension point marked as @deprecated since at
least 6.0. They served as a signpost for plugin authors upgrading from 2.x but
this shouldn't be relevant in 7.0 anymore.