Deprecate HLRC EmptyResponse used by security by hub-cap · Pull Request #37540 · elastic/elasticsearch

hub-cap · 2019-01-16T16:06:10Z

The EmptyResponse is essentially the same as returning a boolean, which
is done in other places. This commit deprecates all the existing
EmptyResponse methods and creates new boolean methods that have method
params reordered so they can exist with the deprecated methods. A
followup PR in master will remove the existing deprecated methods, fix
the parameter ordering and deprecate the incorrectly ordered parameter
methods.

Relates #36938

The EmptyResponse is essentially the same as returning a boolean, which is done in other places. This commit deprecates all the existing EmptyResponse methods and creates new boolean methods that have method params reordered so they can exist with the deprecated methods. A followup PR in master will remove the existing deprecated methods, fix the parameter ordering and deprecate the incorrectly ordered parameter methods. Relates elastic#36938

elasticmachine · 2019-01-16T16:06:13Z

Pinging @elastic/es-core-features

elasticmachine · 2019-01-16T16:06:15Z

Pinging @elastic/es-security

hub-cap · 2019-01-16T16:06:39Z

I went ahead and added the :Security/Security label so yall would be aware, feel free to remove it.

hub-cap · 2019-01-16T20:02:15Z

@elasticmachine run gradle build tests 1

tvernum · 2019-01-16T23:54:38Z

client/rest-high-level/src/main/java/org/elasticsearch/client/SecurityClient.java

+     *
+     * @param options the request options (e.g. headers), use {@link RequestOptions#DEFAULT} if nothing needs to be customized
+     * @param request the request with the user to enable
+     * @return the response from the enable user call


This doesn't make much sense to me since it returns a boolean.

Suggested change

* @return the response from the enable user call

* @return {@code true} if the request succeeded (the user is enabled)

tvernum · 2019-01-16T23:55:40Z

client/rest-high-level/src/main/java/org/elasticsearch/client/SecurityClient.java

+     *
+     * @param options the request options (e.g. headers), use {@link RequestOptions#DEFAULT} if nothing needs to be customized
+     * @param request the request with the user to disable
+     * @return the response from the enable user call


Suggested change

* @return the response from the enable user call

* @return {@code true} if the request succeeded (the user is disabled)

tvernum · 2019-01-16T23:56:39Z

client/rest-high-level/src/main/java/org/elasticsearch/client/SecurityClient.java

+     *
+     * @param options the request options (e.g. headers), use {@link RequestOptions#DEFAULT} if nothing needs to be customized
+     * @param request the request with the user's new password
+     * @return the response from the change user password call


Suggested change

* @return the response from the change user password call

* @return {@code true} if the request succeeded (the new password was set)

tvernum · 2019-01-16T23:57:05Z

client/rest-high-level/src/main/java/org/elasticsearch/client/security/EmptyResponse.java


 /**
 * Response for a request which simply returns an empty object.
+   @deprecated Use a boolean to instead of this class


Suggested change

@deprecated Use a boolean to instead of this class

@deprecated Use a boolean instead of this class

tvernum · 2019-01-16T23:59:06Z

20:39:14 > Task :client:rest-high-level:unitTest FAILED
20:39:14 Tests with failures:
20:39:14 
20:39:14   - org.elasticsearch.client.CustomRestHighLevelClientTests.testMethodsVisibility
20:39:14   - org.elasticsearch.client.RestHighLevelClientTests.testApiNamingConventions
20:39:14 FAILURE: Build failed with an exception.
20:39:14

😿

hub-cap · 2019-01-17T02:18:09Z

ty for the review. Ive fixed the tests and added the wording differences you mentioned above. <3

hub-cap · 2019-01-17T15:25:18Z

@elasticmachine run gradle build tests 1
@elasticmachine run gradle build tests 2

This commit deprecates the few methods that had their parameters reordered to facilitate the move from EmptyResponse to boolean. This commit also readds the boolean based methods with the proper signatures. Relates elastic#37540 Relates elastic#36938

…ty_response

tvernum

LGTM 👍

…ty_response

The EmptyResponse is essentially the same as returning a boolean, which is done in other places. This commit deprecates all the existing EmptyResponse methods and creates new boolean methods that have method params reordered so they can exist with the deprecated methods. A followup PR in master will remove the existing deprecated methods, fix the parameter ordering and deprecate the incorrectly ordered parameter methods. Relates #36938

* elastic/master: Optimize warning header de-duplication (elastic#37725) Bubble exceptions up in ClusterApplierService (elastic#37729) SQL: Improve handling of invalid args for PERCENTILE/PERCENTILE_RANK (elastic#37803) Remove unused ThreadBarrier class (elastic#37666) Add built-in user and role for code plugin (elastic#37030) Consolidate testclusters tests into a single project (elastic#37362) Fix docs for MappingUpdatedAction SQL: Introduce SQL DATE data type (elastic#37693) disabling bwc test while backporting elastic#37639 Mute ClusterDisruptionIT testAckedIndexing Set acking timeout to 0 on dynamic mapping update (elastic#31140) Remove index audit output type (elastic#37707) Mute FollowerFailOverIT testReadRequestsReturnsLatestMappingVersion [ML] Increase close job timeout and lower the max number (elastic#37770) Remove Custom Listeners from SnapshotsService (elastic#37629) Use m_m_nodes from Zen1 master for Zen2 bootstrap (elastic#37701) Fix index filtering in follow info api. (elastic#37752) Use project dependency instead of substitutions for distributions (elastic#37730) Update authenticate to allow unknown fields (elastic#37713) Deprecate HLRC EmptyResponse used by security (elastic#37540)

This commit deprecates the few methods that had their parameters reordered to facilitate the move from EmptyResponse to boolean. This commit also readds the boolean based methods with the proper signatures. Relates elastic#37540 Relates elastic#36938

This commit deprecates the few methods that had their parameters reordered to facilitate the move from EmptyResponse to boolean. This commit also readds the boolean based methods with the proper signatures. Relates #37540 Relates #36938

hub-cap added >enhancement v7.0.0 :Core/Features/Java High Level REST Client :Security/Security Security issues without another label v6.7.0 labels Jan 16, 2019

tvernum reviewed Jan 16, 2019

View reviewed changes

Fix up from comments and the test cases that were broken

56e4827

martijnvg mentioned this pull request Jan 17, 2019

[HLRC] Ensure that response parsers support unknown fields #36938

Closed

25 tasks

Merge remote-tracking branch 'upstream/master' into rest_security_emp…

7973bf9

…ty_response

tvernum approved these changes Jan 22, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master' into rest_security_emp…

f93fd98

…ty_response

hub-cap merged commit 944972a into elastic:master Jan 24, 2019

hub-cap added the backport pending label Jan 24, 2019

hub-cap removed the backport pending label Jan 24, 2019

hub-cap mentioned this pull request Jan 25, 2019

Deprecate HLRC security methods #37883

Merged

hub-cap added the >deprecation label Jan 25, 2019

colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

danielmitterdorfer removed the :Security/Security Security issues without another label label Feb 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate HLRC EmptyResponse used by security#37540

Deprecate HLRC EmptyResponse used by security#37540
hub-cap merged 4 commits intoelastic:masterfrom
hub-cap:rest_security_empty_response

hub-cap commented Jan 16, 2019

Uh oh!

elasticmachine commented Jan 16, 2019

Uh oh!

elasticmachine commented Jan 16, 2019

Uh oh!

hub-cap commented Jan 16, 2019 •

edited

Loading

Uh oh!

hub-cap commented Jan 16, 2019

Uh oh!

tvernum Jan 16, 2019

Uh oh!

tvernum Jan 16, 2019

Uh oh!

tvernum Jan 16, 2019

Uh oh!

tvernum Jan 16, 2019

Uh oh!

tvernum commented Jan 16, 2019

Uh oh!

hub-cap commented Jan 17, 2019

Uh oh!

hub-cap commented Jan 17, 2019

Uh oh!

tvernum left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	* @return the response from the enable user call
	* @return {@code true} if the request succeeded (the user is enabled)

	* @return the response from the change user password call
	* @return {@code true} if the request succeeded (the new password was set)

	@deprecated Use a boolean to instead of this class
	@deprecated Use a boolean instead of this class

Conversation

hub-cap commented Jan 16, 2019

Uh oh!

elasticmachine commented Jan 16, 2019

Uh oh!

elasticmachine commented Jan 16, 2019

Uh oh!

hub-cap commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hub-cap commented Jan 16, 2019

Uh oh!

tvernum Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

tvernum Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

tvernum Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

tvernum Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

tvernum commented Jan 16, 2019

Uh oh!

hub-cap commented Jan 17, 2019

Uh oh!

hub-cap commented Jan 17, 2019

Uh oh!

tvernum left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hub-cap commented Jan 16, 2019 •

edited

Loading