Skip to content

Remove dead code from ShardSearchStats#37421

Merged
s1monw merged 2 commits intoelastic:masterfrom
s1monw:clean_up_search_stats
Jan 15, 2019
Merged

Remove dead code from ShardSearchStats#37421
s1monw merged 2 commits intoelastic:masterfrom
s1monw:clean_up_search_stats

Conversation

@s1monw
Copy link
Copy Markdown
Contributor

@s1monw s1monw commented Jan 14, 2019

The clear methods are unused and unsafe at this point. This commit
removes the dead code.

The clear methodsa are unused and unsafe at this point. This commit
removes the dead code.
@s1monw s1monw added >non-issue :Core/Infra/Stats Statistics tracking and retrieval APIs v7.0.0 v6.7.0 labels Jan 14, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features

Copy link
Copy Markdown
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1monw s1monw merged commit 147c5e6 into elastic:master Jan 15, 2019
s1monw added a commit that referenced this pull request Jan 15, 2019
The clear methodsa are unused and unsafe at this point. This commit
removes the dead code.
@s1monw s1monw deleted the clean_up_search_stats branch January 15, 2019 08:40
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 15, 2019
* elastic/master:
  Docs be explicit on how to turn off deprecated auditing (elastic#37316)
  Fix line length for monitor and remove suppressions (elastic#37456)
  Fix IndexShardTestCase.recoverReplica(IndexShard, IndexShard, boolean) (elastic#37414)
  Update the Flush API documentation (elastic#33551)
  [TEST] Muted testDifferentRolesMaintainPathOnRestart
  Remove dead code from ShardSearchStats (elastic#37421)
  Simplify testSendSnapshotSendsOps (elastic#37445)
  SQL: Fix issue with field names containing "." (elastic#37364)
  Restore lost @Inject annotation (elastic#37452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Stats Statistics tracking and retrieval APIs >non-issue v6.7.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants