Subclass NIOFSDirectory instead of using FileSwitchDirectory#37140
Merged
s1monw merged 4 commits intoelastic:masterfrom Jan 5, 2019
Merged
Subclass NIOFSDirectory instead of using FileSwitchDirectory#37140s1monw merged 4 commits intoelastic:masterfrom
s1monw merged 4 commits intoelastic:masterfrom
Conversation
We don't want two FSDirectories manage pending deletes separately and optimze file listing. This confuses IndexWriter and causes exceptions when files are deleted twice but are pending for deletion. This change move to using a NIOFS subclass that only delegates to MMAP for opening files all metadata and pending deletes are managed on top. Closes elastic#37111 Relates to elastic#36668
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
@danielmitterdorfer can you include this if you backport #36668 |
Member
danielmitterdorfer
left a comment
There was a problem hiding this comment.
Thanks for the fix. I left some comments.
server/src/main/java/org/elasticsearch/index/store/FsDirectoryService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/store/FsDirectoryService.java
Outdated
Show resolved
Hide resolved
Member
The change has already been backported in #37067 but I can take care of backporting this PR here to 6.x. |
Contributor
Author
|
@danielmitterdorfer I pushed changes |
danielmitterdorfer
approved these changes
Jan 4, 2019
Member
danielmitterdorfer
left a comment
There was a problem hiding this comment.
I left a nit but apart from that LGTM. No need for another round. Thanks!
server/src/main/java/org/elasticsearch/index/store/FsDirectoryService.java
Outdated
Show resolved
Hide resolved
s1monw
added a commit
that referenced
this pull request
Jan 5, 2019
We don't want two FSDirectories manage pending deletes separately and optimize file listing. This confuses IndexWriter and causes exceptions when files are deleted twice but are pending for deletion. This change move to using a NIOFS subclass that only delegates to MMAP for opening files all metadata and pending deletes are managed on top. Closes #37111 Relates to #36668
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 9, 2019
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want two FSDirectories manage pending deletes separately
and optimze file listing. This confuses IndexWriter and causes exceptions
when files are deleted twice but are pending for deletion. This change
move to using a NIOFS subclass that only delegates to MMAP for opening files
all metadata and pending deletes are managed on top.
Closes #37111
Relates to #36668