Rename setting to enable mmap#37070
Merged
danielmitterdorfer merged 3 commits intoelastic:masterfrom Jan 3, 2019
Merged
Conversation
With this commit we rename `node.store.allow_mmapfs` to `node.store.allow_mmap`. Previously this setting has controlled whether `mmapfs` could be used as a store type. With the introduction of `hybridfs` which also relies on memory-mapping, `node.store.allow_mmapfs` also applies to `hybridfs` and thus we rename it in order to convey that it is actually used to allow memory-mapping but not a specific store type. Relates elastic#36668
Collaborator
|
Pinging @elastic/es-distributed |
| [float] | ||
| ==== Disabling memory-mapping | ||
|
|
||
| * The deprecated `node.store.allow_mmapfs` setting has been removed in favour of |
Member
Author
There was a problem hiding this comment.
I will create a separate PR on 6.x which introduces node.store.allow_mmapfs as a deprecated setting.
Contributor
There was a problem hiding this comment.
I'm wondering that saying "renamed to" rather than "removed in favour of" might be clearer?
Member
Author
There was a problem hiding this comment.
Makes sense. I changed it now to
The setting
node.store.allow_mmapfshas been renamed tonode.store.allow_mmap.
jpountz
approved these changes
Jan 2, 2019
| [float] | ||
| ==== Disabling memory-mapping | ||
|
|
||
| * The deprecated `node.store.allow_mmapfs` setting has been removed in favour of |
Contributor
There was a problem hiding this comment.
I'm wondering that saying "renamed to" rather than "removed in favour of" might be clearer?
Member
Author
|
@elasticmachine test this please |
danielmitterdorfer
added a commit
that referenced
this pull request
Jan 4, 2019
With this commit we deprecate the setting `node.store.allow_mmapfs` and add a new setting `node.store.allow_mmap`. Previously this setting has controlled whether `mmapfs` could be used as a store type. With the introduction of `hybridfs` which also relies on memory-mapping the old setting name is no longer appropriate as it also applies to `hybridfs`and thus we rename it in order to convey that it is actually used to allow memory-mapping but not a specific store type. Relates #37067 Relates #37070 Relates #37095
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 6, 2019
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 9, 2019
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit we rename
node.store.allow_mmapfstonode.store.allow_mmap. Previously this setting has controlled whethermmapfscould be used as a store type. With the introduction ofhybridfswhich also relies on memory-mapping,node.store.allow_mmapfsalso applies tohybridfsand thus we renameit in order to convey that it is actually used to allow memory-mapping
but not a specific store type.
Relates #36668