Skip to content

SNAPSHOT+TESTS: Speed up Snapshot IT#36990

Merged
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:speedup-snapshot-restore-it
Dec 27, 2018
Merged

SNAPSHOT+TESTS: Speed up Snapshot IT#36990
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:speedup-snapshot-restore-it

Conversation

@original-brownbear
Copy link
Copy Markdown
Contributor

@original-brownbear original-brownbear commented Dec 26, 2018

  • This speeds up the test from an average 25s down to 7s runtime
  • There is no need for artificially slowing down the snapshot to reproduce the issue of an out of sync routing table in practice.
    Over hundreds of test runs the test's snapshot shard service still runs in the index not found exception every time reproducing this issue.
    • Regardless, reordered the creation and setting of the disruption slightly to make running the disruption concurrently to the snapshot even more likely
  • Relates SNAPSHOT: Increase Timeout to Stabilize Test #36294

* This speeds up the test from an average 25s down to 7s runtime
* There is no need for artificially slowing down the snapshot to reproduce the issue of an out of sync routing table in practice.
Over hundreds of test runs the test's snapshot shard service still runs in the index not found exception every time reproducing this issue.
* Relates #36294
@original-brownbear original-brownbear added >non-issue >test Issues or PRs that are addressing/adding tests :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v7.0.0 v6.7.0 labels Dec 26, 2018
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed

Copy link
Copy Markdown
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear original-brownbear merged commit 6aae7c8 into elastic:master Dec 27, 2018
@original-brownbear original-brownbear deleted the speedup-snapshot-restore-it branch December 27, 2018 11:18
@original-brownbear
Copy link
Copy Markdown
Contributor Author

@ywelsch thanks!

original-brownbear added a commit that referenced this pull request Dec 27, 2018
* This speeds up the test from an average 25s down to 7s runtime
* There is no need for artificially slowing down the snapshot to reproduce the issue of an out of sync routing table in practice.
Over hundreds of test runs the test's snapshot shard service still runs in the index not found exception every time reproducing this issue.
* Relates #36294
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue >test Issues or PRs that are addressing/adding tests v6.7.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants