Skip to content

Package ingest-user-agent as a module#36956

Merged
jasontedor merged 3 commits intoelastic:masterfrom
jasontedor:package-ingest-user-agent-as-a-module
Dec 23, 2018
Merged

Package ingest-user-agent as a module#36956
jasontedor merged 3 commits intoelastic:masterfrom
jasontedor:package-ingest-user-agent-as-a-module

Conversation

@jasontedor
Copy link
Copy Markdown
Member

This commit moves ingest-user-agent from being a plugin to being a module that is packaged with Elasticsearch distributions.

This commit moves ingest-user-agent from being a plugin to being a
module that is packaged with Elasticsearch distributions.
@jasontedor jasontedor added >enhancement >breaking :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts :Distributed/Ingest Node Execution or management of Ingest Pipelines v7.0.0 v6.7.0 labels Dec 22, 2018
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra

Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor
Copy link
Copy Markdown
Member Author

@elasticmachine run gradle build tests 1

* master:
  Fix link to using ingest-geoip
  Add placeholder ingest-geoip plugin page (elastic#36958)
Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

if ("ingest-geoip".equals(pluginName)) {
/*
* This is special case handling for ingest-geoip and ingest-user-agent since they are modules now but could have been installed
* from a previous when it was a plugin.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous version?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it in post.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed 02a1b2b directly to master and cherry-picked it to 6.x via 0a03a45.

@jasontedor jasontedor merged commit 1f574bd into elastic:master Dec 23, 2018
jasontedor added a commit that referenced this pull request Dec 23, 2018
This commit moves ingest-user-agent from being a plugin to being a
module that is packaged with Elasticsearch distributions.
@jasontedor jasontedor deleted the package-ingest-user-agent-as-a-module branch December 23, 2018 01:27
@jasontedor
Copy link
Copy Markdown
Member Author

Thanks @martijnvg and @rjernst.

ebadyano added a commit to ebadyano/rally-teams that referenced this pull request Mar 14, 2019
ingest-geoip and ingest-user-agent are now packaged as modules in
Elasticsearch. Relates to elastic/elasticsearch#36956 and
elastic/elasticsearch#36246
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >enhancement Team:Delivery Meta label for Delivery team v6.7.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants