Handle Null in FetchSourceContext#fetchSource#36839
Merged
jkakavas merged 4 commits intoelastic:6.xfrom Dec 21, 2018
Merged
Conversation
This change ensures that when null is passed as the value to one of its Nullable parameters, it is not wrapped in a String array. That would in turn cause a NPE when attempting to serialize FetchSourceContext as its constructor checks for null values only. In master, the problematic behavior was corrected as part of elastic#29293
Collaborator
|
Pinging @elastic/es-core-features |
Contributor
Author
|
@elasticmachine please run the gradle build tests 2 once more as the first time the worker ran out of memory 🐼 |
Contributor
Author
|
@elasticmachine please run the gradle build tests 2, hopefully for the last time |
Contributor
Author
|
Unstable network is unstable @elasticmachine please run the gradle build tests 2 |
jkakavas
added a commit
that referenced
this pull request
Dec 21, 2018
This change ensures that when null is passed as the value to one of UpdateRequest#fetchSource @nullable parameters, it is not wrapped in a String array. That would in turn cause a NPE when attempting to serialize FetchSourceContext as its constructor checks explicitly for Null and not for arrays of Null objects. In master, the problematic behavior was corrected as part of #29293
jkakavas
added a commit
that referenced
this pull request
Dec 21, 2018
This change ensures that when null is passed as the value to one of UpdateRequest#fetchSource @nullable parameters, it is not wrapped in a String array. That would in turn cause a NPE when attempting to serialize FetchSourceContext as its constructor checks explicitly for Null and not for arrays of Null objects. In master, the problematic behavior was corrected as part of #29293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that when null is passed as the value to one of
UpdateRequest#fetchSource
@Nullableparameters, it is not wrapped in aString array. That would in turn cause a NPE when attempting to serialize
FetchSourceContext as its constructor checks explicitly for Null and not for
arrays of Null objects.
In master, the problematic behavior was corrected as part of #29293