Fix line length for IndexLifecycleActionIT#36586
Merged
danielmitterdorfer merged 1 commit intoelastic:masterfrom Dec 14, 2018
Merged
Fix line length for IndexLifecycleActionIT#36586danielmitterdorfer merged 1 commit intoelastic:masterfrom
danielmitterdorfer merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
33 tasks
pgomulka
reviewed
Dec 14, 2018
Contributor
pgomulka
left a comment
There was a problem hiding this comment.
looks good, but one comment
|
|
||
| logger.info("Creating index [test]"); | ||
| CreateIndexResponse createIndexResponse = client().admin().indices().create(createIndexRequest("test").settings(settings)).actionGet(); | ||
| CreateIndexResponse createIndexResponse = client().admin().indices().create( |
Contributor
There was a problem hiding this comment.
I noticed that you break lines on '(' . Was that an intention? Reminds me of my early projects in Lisp :) I am worried that most of other refactoring would be breaking chained methods on '.'
what do you think of breaking on '.'
for instance
client().admin().indices()
.create(reateIndexRequest("test").settings(settings)))
.actionGet();
or even one '.' per each line - although that might have been excessive
Member
Author
There was a problem hiding this comment.
The intention was to separate the request creation from the actual call.
Member
Author
|
Thank you for the review. :) |
Member
Author
|
Backported to 6.x in 7c82b15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #34884