[Painless] Add def to boxed type casts#36506
Merged
jdconrad merged 2 commits intoelastic:masterfrom Dec 11, 2018
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@rjernst Thank you for the review! Will commit as soon as CI is successful. |
jdconrad
added a commit
that referenced
this pull request
Dec 11, 2018
This adds casts for the def type to all standard boxed types. Prior to this certain casts such as def [long/Long] -> Double would fail which does not follow the goals of the Painless casting model to remove the need for explicit boxing. This also creates symmetry with the casts for the newly created bridge methods being called at run-time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds casts for the def type to all standard boxed types. Prior to this certain casts such as
def [long/Long] -> Doublewould fail which does not follow the goals of the Painless casting model to remove the need for explicit boxing. This also creates symmetry with the casts for the newly created bridge methods being called at run-time.