deprecation info API: negative index.unassigned.node_left.delayed_timeout#36454
Merged
jakelandis merged 4 commits intoelastic:6.xfrom Dec 13, 2018
Merged
Conversation
…eout This commit adds support to check for negative values for index setting `index.unassigned.node_left.delayed_timeout` for the deprecation info API. relates elastic#36024 relates elastic#26828
Collaborator
|
Pinging @elastic/es-core-features |
26 tasks
AthenaEryma
suggested changes
Dec 11, 2018
Contributor
AthenaEryma
left a comment
There was a problem hiding this comment.
Left one note about the details message, otherwise looks good. Thanks again!
...in/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecks.java
Outdated
Show resolved
Hide resolved
DaveCTurner
reviewed
Dec 11, 2018
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
I left a couple of nits but structurally this looks good. CI seems to be all kinds of broken here. Perhaps it needs to be merged with a known-good recent commit from master?
...in/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecks.java
Outdated
Show resolved
Hide resolved
...in/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecks.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@gwbrown @DaveCTurner thanks for the reviews. changes implemented. Below is the final output. |
AthenaEryma
approved these changes
Dec 11, 2018
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 12, 2025
When file settings tests look for changes in cluster state to assert application of changes they do so by adding a cluster state listener. But if there are no more cluster state updates after the listener is added the test will never see the initial state of file settings. This commit ensures the current cluster state is seen in that case. closes elastic#36454
rjernst
added a commit
that referenced
this pull request
Nov 18, 2025
When file settings tests look for changes in cluster state to assert application of changes they do so by adding a cluster state listener. But if there are no more cluster state updates after the listener is added the test will never see the initial state of file settings. This commit ensures the current cluster state is seen in that case. closes #36454
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 18, 2025
When file settings tests look for changes in cluster state to assert application of changes they do so by adding a cluster state listener. But if there are no more cluster state updates after the listener is added the test will never see the initial state of file settings. This commit ensures the current cluster state is seen in that case. closes elastic#36454
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 18, 2025
When file settings tests look for changes in cluster state to assert application of changes they do so by adding a cluster state listener. But if there are no more cluster state updates after the listener is added the test will never see the initial state of file settings. This commit ensures the current cluster state is seen in that case. closes elastic#36454
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2025
When file settings tests look for changes in cluster state to assert application of changes they do so by adding a cluster state listener. But if there are no more cluster state updates after the listener is added the test will never see the initial state of file settings. This commit ensures the current cluster state is seen in that case. closes #36454
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2025
When file settings tests look for changes in cluster state to assert application of changes they do so by adding a cluster state listener. But if there are no more cluster state updates after the listener is added the test will never see the initial state of file settings. This commit ensures the current cluster state is seen in that case. closes #36454
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support to check for negative values for index setting
index.unassigned.node_left.delayed_timeoutfor the deprecation info API.relates #36024
relates #26828