[Zen2] Hide not recovered state#36224
Merged
ywelsch merged 10 commits intoelastic:zen2from Dec 5, 2018
Merged
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
suggested changes
Dec 5, 2018
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
I've request one small change to the hiding logic, o.w. looking good.
| @Override | ||
| protected Settings nodeSettings(int nodeOrdinal) { | ||
| return Settings.builder().put(super.nodeSettings(nodeOrdinal)) | ||
| .put(TestZenDiscovery.USE_ZEN2.getKey(), false) // no state persistence yet |
| internalCluster().stopRandomDataNode(); | ||
| internalCluster().stopRandomDataNode(); | ||
| internalCluster().fullRestart(); | ||
| internalCluster().stopRandomNode(InternalTestCluster.nameFilter(nodes.get(1))); |
Contributor
There was a problem hiding this comment.
to readd more randomization, maybe write nodes.get(1), nodes.get(2) both here and in the next line.
| @Override | ||
| protected Settings nodeSettings(int nodeOrdinal) { | ||
| return Settings.builder().put(super.nodeSettings(nodeOrdinal)) | ||
| .put(TestZenDiscovery.USE_ZEN2.getKey(), false) // no state persistence yet |
added 2 commits
December 5, 2018 15:09
Contributor
Author
|
@ywelsch I've fixed nits, for some reason I don't see your comments regarding changing hiding logic, can you please comment again? |
Contributor
|
weird, my comment has disappeared. I had asked for the hiding logic to keep the coordinationmetadata and the cluster uuid in the empty metadata, as these are particularly useful at this stage where the state might not be recovered yet, but the cluster state is already accessible through the cluster state API. |
Contributor
Author
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 6, 2018
* master: (133 commits) SNAPSHOT: Increase Timeout to Stabilize Test (elastic#36294) Fix get certificates HLRC API (elastic#36198) Avoid shutting down the only master (elastic#36272) Fix typo in comment Fix total hits serialization of the search response (elastic#36290) Fix FullClusterRestartIT#testRollupIDSchemeAfterRestart Mute FullClusterRestartIT#testRollupIDSchemeAfterRestart as we await a fix. [Docs] Add Profile API limitations (elastic#36252) Make sure test don't use Math.random for reproducability (elastic#36241) Fix compilation ingest: support default pipeline through an alias (elastic#36231) Zen2: Rename tombstones to exclusions (elastic#36226) [Zen2] Hide not recovered state (elastic#36224) Test: mute testDataNodeRestartWithBusyMasterDuringSnapshot Test: mute testSnapshotAndRestoreWithNested Revert "Test: mute failing mtermvector rest test" Test: mute failing mtermvector rest test add version 6.5.3 (elastic#36268) Make hits.total an object in the search response (elastic#35849) [DOCS] Fixes broken link in execute watch ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hides
ClusterState, that hasSTATE_NOT_RECOVERED_BLOCK,from
ClusterStateAppliers.This is needed, because some appliers, such as
IngestService, rely onthe fact, that cluster state with
STATE_NOT_RECOVERED_BLOCKwon'tcontain anything useful.
Once the state is recovered it's fully available for the appliers.
Also, this PR switches most of the tests that require persistence/state
recovery from Zen1 to Zen2.
There are still the following tests, that were assumed to work after
persistence/recovery is implemented, but do not, namely:
PrimaryAllocationIT- fixed with 7d26c64testIndexDeletionWhenNodeRejoins