[HLRC] Added support for CCR Get Auto Follow Pattern apis#36049
Merged
martijnvg merged 2 commits intoelastic:masterfrom Dec 4, 2018
Merged
[HLRC] Added support for CCR Get Auto Follow Pattern apis#36049martijnvg merged 2 commits intoelastic:masterfrom
martijnvg merged 2 commits intoelastic:masterfrom
Conversation
This change also adds documentation for the Get Auto Follow Pattern API. Relates to elastic#33824
Collaborator
|
Pinging @elastic/es-core-features |
9 tasks
hub-cap
approved these changes
Dec 3, 2018
Contributor
hub-cap
left a comment
There was a problem hiding this comment.
heh you know the HLRC PR process well now. Great work.
martijnvg
added a commit
that referenced
this pull request
Dec 4, 2018
This change also adds documentation for the Get Auto Follow Pattern API. Relates to #33824
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Dec 4, 2018
The current response format is:
```
{
"pattern1": {
...
},
"pattern2": {
...
}
}
```
The new format is:
```
{
"patterns": [
{
"name": "pattern1",
"pattern": {
...
}
},
{
"name": "pattern2",
"pattern": {
...
}
}
]
}
```
This format is more structured and more friendly for parsing and generating specs.
This is a breaking change, but it is better to do this now while ccr
is still a beta feature than later.
Follow up from elastic#36049
spinscale
pushed a commit
that referenced
this pull request
Dec 4, 2018
This change also adds documentation for the Get Auto Follow Pattern API. Relates to #33824
martijnvg
added a commit
that referenced
this pull request
Dec 5, 2018
The current response format is:
```
{
"pattern1": {
...
},
"pattern2": {
...
}
}
```
The new format is:
```
{
"patterns": [
{
"name": "pattern1",
"pattern": {
...
}
},
{
"name": "pattern2",
"pattern": {
...
}
}
]
}
```
This format is more structured and more friendly for parsing and generating specs.
This is a breaking change, but it is better to do this now while ccr
is still a beta feature than later.
Follow up from #36049
martijnvg
added a commit
that referenced
this pull request
Dec 5, 2018
The current response format is:
```
{
"pattern1": {
...
},
"pattern2": {
...
}
}
```
The new format is:
```
{
"patterns": [
{
"name": "pattern1",
"pattern": {
...
}
},
{
"name": "pattern2",
"pattern": {
...
}
}
]
}
```
This format is more structured and more friendly for parsing and generating specs.
This is a breaking change, but it is better to do this now while ccr
is still a beta feature than later.
Follow up from #36049
48 tasks
Contributor
|
Hi @martijnvg, this appears to be a breaking change in the response format between versions Examples:
We have a mechanism by which we can workaround this breaking change in the .NET client (a custom derserializer), but I wanted to check the reasoning behind this change? Are there any intentions to add sibling json nodes to the "patterns" node? Thanks! |
Member
Author
|
Hey @codebrain This breaking change was part of #36203, which also describes the reasoning.
No, at the moment there are no plans for this. But this will allow us to do so in the future if needed. |
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change also adds documentation for the Get Auto Follow Pattern API.
Relates to #33824