[TEST] Use deprecated form of rollup endpoint in mixed cluster#36000
Merged
polyfractal merged 1 commit intoelastic:masterfrom Nov 29, 2018
Merged
Conversation
When wiping rollup jobs, if we are in a mixed cluster with < v7.0 nodes we need to fall back to the deprecated endpoint because we may talk to a 6.x node.
Collaborator
|
Pinging @elastic/es-analytics-geo |
nik9000
reviewed
Nov 28, 2018
Member
nik9000
left a comment
There was a problem hiding this comment.
I expect this'll come up for all of the xpack components that clean up with http. Some of them will be here, others will be scattered in weird parts of xpack.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Dec 10, 2018
…d cluster (elastic#36000)"" This reverts commit 40c5445.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When wiping rollup jobs, if we are in a mixed cluster with < v7.0 nodes we need to fall back to the deprecated endpoint because we may talk to a 6.x node.
Putting up for a CI run and because BWC tests break my brain so eyeballs make me feel better :)
I don't know where the other xpack plugins do their cleanup, but I suspect they could run into a similar issue.
Closes #35979, related to #35962