Skip to content

SQL: Polish grammar for intervals#35853

Merged
costin merged 1 commit intoelastic:masterfrom
costin:interval-grammar-polish
Nov 23, 2018
Merged

SQL: Polish grammar for intervals#35853
costin merged 1 commit intoelastic:masterfrom
costin:interval-grammar-polish

Conversation

@costin
Copy link
Copy Markdown
Member

@costin costin commented Nov 23, 2018

Remove unused grammar declaration and minor polishing inside parser.

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search

@costin costin requested review from astefan and matriv November 23, 2018 12:06
@costin costin force-pushed the interval-grammar-polish branch from 2d0bdc7 to 08ee214 Compare November 23, 2018 12:06
Copy link
Copy Markdown
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin
Copy link
Copy Markdown
Member Author

costin commented Nov 23, 2018

Thanks

@costin costin merged commit e22a835 into elastic:master Nov 23, 2018
@costin costin deleted the interval-grammar-polish branch November 23, 2018 15:14
costin added a commit that referenced this pull request Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants