SQL: Add filtering to SYS TYPES#35852
Merged
costin merged 4 commits intoelastic:masterfrom Nov 26, 2018
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search |
matriv
approved these changes
Nov 23, 2018
.../plugin/sql/src/main/java/org/elasticsearch/xpack/sql/plan/logical/command/sys/SysTypes.java
Show resolved
Hide resolved
astefan
approved these changes
Nov 23, 2018
Contributor
astefan
left a comment
There was a problem hiding this comment.
Left two questions. LGTM otherwise.
| public void testSysTypes() throws Exception { | ||
| Command cmd = sql("SYS TYPES").v1(); | ||
|
|
||
| List<String> names = asList("BYTE", "LONG", "BINARY", "NULL", "INTEGER", "SHORT", "HALF_FLOAT", "SCALED_FLOAT", "FLOAT", "DOUBLE", |
Contributor
There was a problem hiding this comment.
Why defining these manually? Probably, small chances there will be new data types added in the future, but it's still a safer way to have DataType populate the List?
Member
Author
There was a problem hiding this comment.
Because the order is different than that of the enum declaration. We could add sorting to it but then it would be the same logic as the one in the code and I wanted to check that manually.
...in/sql/src/test/java/org/elasticsearch/xpack/sql/plan/logical/command/sys/SysTypesTests.java
Show resolved
Hide resolved
Member
Author
|
run the gradle build tests 1 |
Contributor
|
@costin just noticed that the issue you're referencing is not correct? |
Member
Author
|
@matriv the PR comment was picked from the commit comment which was indeed incorrect. I've updated both of them. |
costin
added a commit
that referenced
this pull request
Nov 26, 2018
costin
added a commit
that referenced
this pull request
Nov 26, 2018
costin
added a commit
that referenced
this pull request
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #35342