[HLRC][ML] Add ML find file structure API#35833
Merged
droberts195 merged 2 commits intoelastic:masterfrom Nov 23, 2018
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core |
98 tasks
edsavage
approved these changes
Nov 22, 2018
Contributor
edsavage
left a comment
There was a problem hiding this comment.
LGTM - just one question
| private final List<String> jodaTimestampFormats; | ||
| private final List<String> javaTimestampFormats; | ||
| private final String timestampField; | ||
| private final boolean needClientTimezone; |
Author
There was a problem hiding this comment.
boolean matches the server side. This one is boolean rather than Boolean because it's always present in the output. The other flags are sometimes not set at all.
droberts195
added a commit
that referenced
this pull request
Nov 23, 2018
original-brownbear
pushed a commit
that referenced
this pull request
Nov 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #29827