Revert "Use more precise does S3 bucket exist method"#35732
Merged
ywelsch merged 1 commit intoelastic:6.5from Nov 26, 2018
Merged
Revert "Use more precise does S3 bucket exist method"#35732ywelsch merged 1 commit intoelastic:6.5from
ywelsch merged 1 commit intoelastic:6.5from
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
tlrx
approved these changes
Nov 21, 2018
Member
tlrx
left a comment
There was a problem hiding this comment.
LGTM - Sorry, it went out of my radar.
Member
There was a problem hiding this comment.
I don't think you wanted to change this?
Member
There was a problem hiding this comment.
It's a pure revert of my previous commit, where I did fix the formatting here. I'm okay with undoing the formatting fix in favor of a pure revert.
This reverts commit da71d66.
fe139f2 to
1fd6376
Compare
Contributor
Author
|
@elasticmachine run the oss docs tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #34123 which breaks compatibility with our documented IAM policies (see #35703).
For 6.6 and beyond, I've opened #35731 that addresses this in a different way.