Fix PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary#35728
Merged
vladimirdolzhenko merged 4 commits intoelastic:masterfrom Nov 20, 2018
Merged
Fix PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary#35728vladimirdolzhenko merged 4 commits intoelastic:masterfrom
vladimirdolzhenko merged 4 commits intoelastic:masterfrom
Conversation
grab in-sync set of the 1st cluster state change after reroute execution Closes 35497
Collaborator
|
Pinging @elastic/es-distributed |
DaveCTurner
reviewed
Nov 20, 2018
server/src/test/java/org/elasticsearch/cluster/routing/PrimaryAllocationIT.java
Show resolved
Hide resolved
added 2 commits
November 20, 2018 16:12
DaveCTurner
reviewed
Nov 20, 2018
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Looks good. Asked for a bit more logging just in case it fails again.
server/src/test/java/org/elasticsearch/cluster/routing/PrimaryAllocationIT.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/routing/PrimaryAllocationIT.java
Show resolved
Hide resolved
Contributor
Author
|
thanks @DaveCTurner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure described in #35497 could be reproduced under load or just adding some delay in between reroute command execution and getting cluster state (allocation ids) - in that case recovery already passed and allocation ids contain actual node id rather expected allocation id right after command execution.
The fix is to grab in-sync set of the 1st cluster state change after reroute execution from
ClusterServiceof the node.Closes #35497