Add high-level REST client API for `_freeze` and `_unfreeze` by s1monw · Pull Request #35723 · elastic/elasticsearch

s1monw · 2018-11-20T08:22:22Z

This change adds support for _freeze and _unfreeze to the HLRC

Relates to #34352

This change adds support for `_freeze` and `_unfreeze` to the HLRC Relates to elastic#34352

javanna

I have left a bunch of minor comments, I think we also need docs for these new hlrc API. @hub-cap and/or @nik9000 can you also look at some of my questions, please?

client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesRequestConverters.java

client/rest-high-level/src/main/java/org/elasticsearch/client/ShardAcknowledgedResponse.java

client/rest-high-level/src/main/java/org/elasticsearch/client/FreezeIndexRequest.java

client/rest-high-level/src/main/java/org/elasticsearch/client/ShardAcknowledgedResponse.java

client/rest-high-level/src/main/java/org/elasticsearch/client/UnfreezeIndexRequest.java

client/rest-high-level/src/main/java/org/elasticsearch/client/FreezeIndexRequest.java

javanna · 2018-11-20T09:20:54Z

client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesRequestConverters.java

        return req;
    }
+
+    static Request freezeIndex(FreezeIndexRequest freezeIndexRequest) {


just double checking that these should be added with all the other OSS API, I think it makes sense but let's be sure.
Does it make sense to add unit testing for these to IndicesRequestConvertersTests?

everything is OSS in this package the serverside might not be

I think that its fine that indices type things can be in the IndicesClient, regardless of their status of commercial/noncommercial.

s1monw · 2018-11-20T10:14:55Z

@javanna I addressed your comments

hub-cap

Agree on the need for docs and the minor comments below.

client/rest-high-level/src/main/java/org/elasticsearch/client/FreezeIndexRequest.java

client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java

hub-cap · 2018-11-21T04:41:19Z

client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesRequestConverters.java

        return req;
    }
+
+    static Request freezeIndex(FreezeIndexRequest freezeIndexRequest) {


I think that its fine that indices type things can be in the IndicesClient, regardless of their status of commercial/noncommercial.

client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java

client/rest-high-level/src/main/java/org/elasticsearch/client/UnfreezeIndexRequest.java

client/rest-high-level/src/main/java/org/elasticsearch/client/core/AcknowledgedRequest.java

s1monw · 2018-11-21T16:52:00Z

Agree on the need for docs

where are the docs missing?

s1monw · 2018-11-21T16:53:16Z

@hub-cap @javanna I pushed new commits

hub-cap

Nits on the docs, and pls move the requests into o.e.c.indices

client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java

docs/java-rest/high-level/indices/freeze_index.asciidoc

docs/java-rest/high-level/supported-apis.asciidoc

s1monw · 2018-11-26T21:04:26Z

@hub-cap I pushed new commits

hub-cap

lgtm

This change adds support for `_freeze` and `_unfreeze` to the HLRC Relates to #34352

Add high-level REST client API for _freeze and _unfreeze

f1f26ab

This change adds support for `_freeze` and `_unfreeze` to the HLRC Relates to elastic#34352

s1monw added >enhancement v7.0.0 :Core/Java High Level REST Client v6.6.0 labels Nov 20, 2018

s1monw requested a review from javanna November 20, 2018 08:22

javanna reviewed Nov 20, 2018

View reviewed changes

apply review comments

946ea10

add license header

90c0f6c

s1monw mentioned this pull request Nov 20, 2018

Frozen Indices #34352

Closed

7 tasks

s1monw requested review from hub-cap and nik9000 November 20, 2018 21:04

hub-cap suggested changes Nov 21, 2018

View reviewed changes

Merge branch 'master' into frozen_hlrc

bb17ced

address comments

75ea7ac

s1monw requested review from hub-cap and javanna November 21, 2018 16:52

s1monw added 7 commits November 21, 2018 18:05

Fix compilation

fcff429

fix checkstyle violation

4c67d80

Merge branch 'master' into frozen_hlrc

2f8f56c

WIP

a70e313

Merge branch 'master' into frozen_hlrc

5cbcc4d

add HLRC docs

5cb84a6

link docs

afd5bcf

hub-cap suggested changes Nov 26, 2018

View reviewed changes

client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java Outdated Show resolved Hide resolved

docs/java-rest/high-level/indices/freeze_index.asciidoc Outdated Show resolved Hide resolved

docs/java-rest/high-level/supported-apis.asciidoc Outdated Show resolved Hide resolved

s1monw added 2 commits November 26, 2018 21:58

Merge branch 'master' into frozen_hlrc

ed6cfe0

apply feedback

225f7c1

s1monw requested a review from hub-cap November 26, 2018 21:04

s1monw added 4 commits November 27, 2018 07:43

Merge branch 'master' into frozen_hlrc

e4cb3b3

Merge branch 'master' into frozen_hlrc

6a9bd63

Merge branch 'master' into frozen_hlrc

d9e7501

add consistency to the docs

fe49988

hub-cap approved these changes Nov 28, 2018

View reviewed changes

s1monw merged commit 89e4ac8 into elastic:master Nov 28, 2018

s1monw deleted the frozen_hlrc branch November 28, 2018 14:42

s1monw added the backport pending label Nov 28, 2018

s1monw added a commit that referenced this pull request Nov 28, 2018

Add high-level REST client API for _freeze and _unfreeze (#35723)

571206d

This change adds support for `_freeze` and `_unfreeze` to the HLRC Relates to #34352

s1monw removed the backport pending label Nov 28, 2018

colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Conversation

s1monw commented Nov 20, 2018

Uh oh!

javanna left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javanna Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

s1monw Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

hub-cap Nov 21, 2018

Choose a reason for hiding this comment

Uh oh!

s1monw commented Nov 20, 2018

Uh oh!

hub-cap left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hub-cap Nov 21, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s1monw commented Nov 21, 2018

Uh oh!

s1monw commented Nov 21, 2018

Uh oh!

hub-cap left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s1monw commented Nov 26, 2018

Uh oh!

hub-cap left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants