Allow to specify highlighter parameters on a per field level basis#356
Closed
lukas-vlcek wants to merge 1 commit intoelastic:masterfrom
lukas-vlcek:73200c9d1ee5fd288182417138428dbfd8b70c80
Closed
Allow to specify highlighter parameters on a per field level basis#356lukas-vlcek wants to merge 1 commit intoelastic:masterfrom lukas-vlcek:73200c9d1ee5fd288182417138428dbfd8b70c80
lukas-vlcek wants to merge 1 commit intoelastic:masterfrom
lukas-vlcek:73200c9d1ee5fd288182417138428dbfd8b70c80
Conversation
Member
|
Few changes that I plan to push:
|
Member
|
Allow to specify highlighter parameters on a per field level basis, closed by cc1eac1. |
Contributor
Author
|
Cool, just the javadoc needs to be updated according to the changes: http://github.com/elasticsearch/elasticsearch/blob/cc1eac147a5278b46dfa18481dbbd2ed2461aa19/modules/elasticsearch/src/main/java/org/elasticsearch/search/highlight/HighlighterParseElement.java#L44 |
Contributor
Author
|
There is one major issue. If numberOfFragments is 0 then the Highlighter does not produce any fragments. Dirty workaround is to add the following line of code after this line: http://github.com/elasticsearch/elasticsearch/blob/cc1eac147a5278b46dfa18481dbbd2ed2461aa19/modules/elasticsearch/src/main/java/org/elasticsearch/search/highlight/HighlightPhase.java#L100 |
Contributor
Author
|
I think it needs to be set to any number greater then 0. I did not check the Lucene source code but after I did the above change then the highlighter correctly yielded whole field content with highlighted text. |
Member
|
applied. |
alpar-t
added a commit
to alpar-t/elasticsearch
that referenced
this pull request
May 9, 2018
- Apply workaround for: GradleUp/shadow#336 - bump plugin to 2.0.4 Changes between 2.0.2 and 2.0.4 of the plugin: ``` 477db40 12 days ago john.engelman@target.com Release 2.0.4 3e3da37 3 weeks ago john.engelman@target.com Remove internal Gradle API and annotation internal getters on shadow jar. 31e2380 3 weeks ago john.engelman@target.com Close input streams. Closes elastic#364 f712cc8 3 weeks ago john.engelman@target.com Upgrade ASM to 6.1.1 to address perf issues. Closes elastic#374 2f94b2b 3 weeks ago john.engelman@target.com next version 23bbf3d 7 weeks ago john.r.engelman@gmail.com Add some gradle versions. Update changelog for 2.0.3 7435c74 7 weeks ago john.r.engelman@gmail.com Merge pull request elastic#367 from ttsiebzehntt/366-java10 325c002 7 weeks ago info@martinsadowski.de Update ASM to 6.1 94550e5 3 months ago john.r.engelman@gmail.com Merge pull request elastic#356 from sgnewson/update-file-to-files 66b691e 4 months ago john.r.engelman@gmail.com Merge pull request elastic#358 from 3flex/patch-1 14761b1 4 months ago 3flex@users.noreply.github.com fix markdown for User Guide URL in issue template a3f6984 4 months ago newson@synopsys.com update inputs.file to inputs.files, to remove warning ``` closes elastic#30389
alpar-t
added a commit
that referenced
this pull request
May 10, 2018
* Solve Gradle deprecation warnings around shadowJar - Apply workaround for: GradleUp/shadow#336 - bump plugin to 2.0.4 Changes between 2.0.2 and 2.0.4 of the plugin: ``` 477db40 12 days ago john.engelman@target.com Release 2.0.4 3e3da37 3 weeks ago john.engelman@target.com Remove internal Gradle API and annotation internal getters on shadow jar. 31e2380 3 weeks ago john.engelman@target.com Close input streams. Closes #364 f712cc8 3 weeks ago john.engelman@target.com Upgrade ASM to 6.1.1 to address perf issues. Closes #374 2f94b2b 3 weeks ago john.engelman@target.com next version 23bbf3d 7 weeks ago john.r.engelman@gmail.com Add some gradle versions. Update changelog for 2.0.3 7435c74 7 weeks ago john.r.engelman@gmail.com Merge pull request #367 from ttsiebzehntt/366-java10 325c002 7 weeks ago info@martinsadowski.de Update ASM to 6.1 94550e5 3 months ago john.r.engelman@gmail.com Merge pull request #356 from sgnewson/update-file-to-files 66b691e 4 months ago john.r.engelman@gmail.com Merge pull request #358 from 3flex/patch-1 14761b1 4 months ago 3flex@users.noreply.github.com fix markdown for User Guide URL in issue template a3f6984 4 months ago newson@synopsys.com update inputs.file to inputs.files, to remove warning ``` closes #30389 * Improove comment as suggested
ClaudioMFreitas
pushed a commit
to ClaudioMFreitas/elasticsearch-1
that referenced
this pull request
Nov 12, 2019
Moving to https for instructions
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 11, 2026
This change provides an implementation for deleting local Lucene files on indexing shards . This way the disk space required for indexing remains as small as possible, allowing in the future to fit "one more shard" on demand. The implementation is based on 3 changes: - IndexDirectory can be notified when a commit is successfully uploaded to the object store. This is required to mark local files as "uploaded". Once marked as uploaded commit files can be accessed through the shared cache (similarly to what is done on search shards) and can be deleted from disk if nothing is actively reading from them. - IndexDirectory can track the Lucene files created for new segments and maintains some RefCounted object for every file (see LocalFileRef), which can be checked to know if the file can be read locally from disk or if it must be read from the shared cache. - ReopeningIndexInput can read from a regular IndexInput and checks before every operation if the corresponding LocalFileRef object allows the operation. If not, it means that the file is/will be deleted from disk, and ReopeningIndexInput reopens a new IndexInput from the shared cache and restores the position/state. Otherwise it reads/clones/slices from the original IndexInput. Local Lucene files are marked as uploaded (and become candidates for deletion) as soon as the commit is uploaded to the object store. The impact of this change on indexing is OK for append-only use cases but is very impacting for update use cases. We will work on improving this in the future.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it is possible to override global highlighter settings at the field level. On top of this it is also possible to specify "fragment_type" : "content" which will return highlighted content of the field (no fragments).