Add a _freeze / _unfreeze API#35592
Merged
s1monw merged 42 commits intoelastic:masterfrom Nov 20, 2018
Merged
Conversation
This commit adds a rest endpoint for freezing and unfreezing an index. Among other cleanups mainly fixing an issue accessing package private APIs from a plugin that got caught by integration tests this change also adds documentation for frozen indices. Note: frozen indices are marked as `beta` and available as a basic feature. Relates to elastic#34352
Collaborator
|
Pinging @elastic/es-distributed |
clintongormley
approved these changes
Nov 15, 2018
Contributor
clintongormley
left a comment
There was a problem hiding this comment.
LGTM once changes are merged
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
Co-Authored-By: s1monw <simonw@apache.org>
s1monw
commented
Nov 15, 2018
lcawl
reviewed
Nov 16, 2018
tlrx
approved these changes
Nov 19, 2018
Member
tlrx
left a comment
There was a problem hiding this comment.
LGTM, I left only minor comments.
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/src/test/resources/rest-api-spec/test/indices.freeze/10_basic.yml
Show resolved
Hide resolved
x-pack/plugin/src/test/resources/rest-api-spec/test/indices.freeze/10_basic.yml
Show resolved
Hide resolved
bleskes
reviewed
Nov 19, 2018
Contributor
bleskes
left a comment
There was a problem hiding this comment.
Looks great. I left some comments and questions.
server/src/main/java/org/elasticsearch/cluster/metadata/MetaDataIndexStateService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/XPackClientPlugin.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Show resolved
Hide resolved
x-pack/plugin/core/src/test/java/org/elasticsearch/index/engine/FrozenIndexRecoveryTests.java
Outdated
Show resolved
Hide resolved
s1monw
added a commit
that referenced
this pull request
Nov 20, 2018
This commit adds a rest endpoint for freezing and unfreezing an index. Among other cleanups mainly fixing an issue accessing package private APIs from a plugin that got caught by integration tests this change also adds documentation for frozen indices. Note: frozen indices are marked as `beta` and available as a basic feature. Relates to #34352
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a rest endpoint for freezing and unfreezing an index.
Among other cleanups mainly fixing an issue accessing package private APIs
from a plugin that got caught by integration tests this change also adds
documentation for frozen indices.
Note: frozen indices are marked as
betaand available as a basic feature.Relates to #34352