Skip to content

Warn if using no default field with large mapping#35570

Merged
cbuescher merged 3 commits intomasterfrom
geekpete-patch-docs-querystring-1
Nov 19, 2018
Merged

Warn if using no default field with large mapping#35570
cbuescher merged 3 commits intomasterfrom
geekpete-patch-docs-querystring-1

Conversation

@geekpete
Copy link
Copy Markdown
Contributor

@geekpete geekpete commented Nov 14, 2018

Warn about potential performance impact when a large number of fields in mapping with _source disabled is used with query string query and no default field.

@geekpete
Warn if using no default field with large mapping
32218df 
Warn about potential performance impact when a large number of fields in mapping with _source disabled is used with query string query and no default field.
@geekpete geekpete added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories labels Nov 14, 2018
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Nov 14, 2018

Pinging @elastic/es-search-aggs

cbuescher
cbuescher requested changes Nov 15, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @geekpete, I left a note, can you take a look at the part above in this doc and let me know if that would cover what you would like to add here?

@geekpete
Removed mention of _source field
6361900 
Also wrapped at 80 columns
cbuescher
cbuescher approved these changes Nov 16, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, LGTM.

@cbuescher cbuescher self-assigned this Nov 16, 2018
@geekpete
Copy link
Copy Markdown
Contributor Author

geekpete commented Nov 19, 2018

@elasticmachine retest this please

@cbuescher cbuescher merged commit 6d8af97 into master Nov 19, 2018
cbuescher pushed a commit that referenced this pull request Nov 19, 2018
@geekpete
[Docs] Warn about searching across all fields wt. query_string (#35570
4cf0086 
)

Warn about potential performance impact when a large number of fields
is used with query string query and no default field.
@geekpete geekpete deleted the geekpete-patch-docs-querystring-1 branch December 3, 2018 02:37
@jrodewig jrodewig mentioned this pull request Apr 28, 2020
Merged
jrodewig added a commit that referenced this pull request Apr 28, 2020
@jrodewig @geekpete
[DOCS] Warn about searching across all fields wt. query_string (#55853
3791a92 
)

Warn about potential performance impact when a large number of fields
is used with query string query and no default field.

Re-adds content from #35570.
That content was erroneously removed in #45296.

Co-authored-by: Peter Dyson <peter.dyson@geekpete.com>
jrodewig added a commit that referenced this pull request Apr 28, 2020
@jrodewig @geekpete
[DOCS] Warn about searching across all fields wt. query_string (#55853
452be22 
)

Warn about potential performance impact when a large number of fields
is used with query string query and no default field.

Re-adds content from #35570.
That content was erroneously removed in #45296.

Co-authored-by: Peter Dyson <peter.dyson@geekpete.com>
jrodewig added a commit that referenced this pull request Apr 28, 2020
@jrodewig @geekpete
[DOCS] Warn about searching across all fields wt. query_string (#55853
7da7fd0 
)

Warn about potential performance impact when a large number of fields
is used with query string query and no default field.

Re-adds content from #35570.
That content was erroneously removed in #45296.

Co-authored-by: Peter Dyson <peter.dyson@geekpete.com>
jrodewig added a commit that referenced this pull request Apr 28, 2020
@jrodewig @geekpete
[DOCS] Warn about searching across all fields wt. query_string (#55853
80177d8 
)

Warn about potential performance impact when a large number of fields
is used with query string query and no default field.

Re-adds content from #35570.
That content was erroneously removed in #45296.

Co-authored-by: Peter Dyson <peter.dyson@geekpete.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees

@cbuescher cbuescher

Labels

>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v6.6.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@geekpete @elasticmachine @cbuescher @colings86