[ILM] TEST: skip checking _ilm/explain response b/c flaky timing#35562
Merged
talevy merged 3 commits intoelastic:masterfrom Nov 15, 2018
Merged
[ILM] TEST: skip checking _ilm/explain response b/c flaky timing#35562talevy merged 3 commits intoelastic:masterfrom
talevy merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
|
While I understand the difficulty in this particular instance, I think it would be good to see if there's any adjustments we can make to the doc test framework to make this work - they caught an issue in these docs that I accidentally introduced in #35524 just yesterday. |
dakrone
approved these changes
Nov 14, 2018
Member
dakrone
left a comment
There was a problem hiding this comment.
While it'd be great if we could solve this with the docs testing infrastructure, for now this is the best option so we don't see more failures coming from these docs
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Nov 22, 2018
talevy
added a commit
that referenced
this pull request
Nov 26, 2018
talevy
added a commit
that referenced
this pull request
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35515.