[HLRC] Add support for get application privileges API#35556
Merged
jkakavas merged 11 commits intoelastic:masterfrom Nov 21, 2018
Merged
[HLRC] Add support for get application privileges API#35556jkakavas merged 11 commits intoelastic:masterfrom
jkakavas merged 11 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-security |
Collaborator
|
Pinging @elastic/es-core-infra |
98 tasks
bizybot
suggested changes
Nov 15, 2018
Contributor
bizybot
left a comment
There was a problem hiding this comment.
Left some comments, otherwise lgtm.
...nt/rest-high-level/src/main/java/org/elasticsearch/client/security/GetPrivilegesRequest.java
Outdated
Show resolved
Hide resolved
...t/rest-high-level/src/main/java/org/elasticsearch/client/security/GetPrivilegesResponse.java
Outdated
Show resolved
Hide resolved
...el/src/main/java/org/elasticsearch/client/security/user/privileges/ApplicationPrivilege.java
Outdated
Show resolved
Hide resolved
...t/rest-high-level/src/test/java/org/elasticsearch/client/SecurityRequestConvertersTests.java
Show resolved
Hide resolved
...nt/rest-high-level/src/main/java/org/elasticsearch/client/security/GetPrivilegesRequest.java
Outdated
Show resolved
Hide resolved
...high-level/src/test/java/org/elasticsearch/client/documentation/SecurityDocumentationIT.java
Outdated
Show resolved
Hide resolved
...el/src/main/java/org/elasticsearch/client/security/user/privileges/ApplicationPrivilege.java
Show resolved
Hide resolved
...high-level/src/test/java/org/elasticsearch/client/documentation/SecurityDocumentationIT.java
Outdated
Show resolved
Hide resolved
...t-high-level/src/test/java/org/elasticsearch/client/security/GetPrivilegesResponseTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@bizybot Thanks for the feedback and the quick turnaround, I have addressed your comments and this is ready for another look |
bizybot
approved these changes
Nov 15, 2018
Contributor
bizybot
left a comment
There was a problem hiding this comment.
other than a small correction in the docs, LGTM, Thank you.
client/rest-high-level/src/main/java/org/elasticsearch/client/SecurityRequestConverters.java
Outdated
Show resolved
Hide resolved
...t/rest-high-level/src/test/java/org/elasticsearch/client/SecurityRequestConvertersTests.java
Show resolved
Hide resolved
albertzaharovits
approved these changes
Nov 20, 2018
Contributor
albertzaharovits
left a comment
There was a problem hiding this comment.
I've noticed a bug that should be fixed, but other than that LGTM .
Contributor
Author
|
@albertzaharovits will you take another look please at the implemented changes for the bug you caught? |
jkakavas
added a commit
that referenced
this pull request
Nov 21, 2018
This commits adds support for the Get Application Privileges API to the HLRC Relates: #29827
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits adds support for the Get Application Privileges
API to the HLRC
Relates: #29827