[HLRC][ML] Add ML delete model snapshot API#35537
Merged
edsavage merged 4 commits intoelastic:masterfrom Nov 15, 2018
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core |
Collaborator
|
Pinging @elastic/es-core-infra |
…e/add-ml-delete-model-snapshot-to-hlrc
benwtrent
reviewed
Nov 14, 2018
| public class DeleteModelSnapshotRequest extends ActionRequest { | ||
|
|
||
| private String jobId; | ||
| private String snapshotId; |
Member
There was a problem hiding this comment.
Both of these should be final
| */ | ||
| public void setSnapshotId(String snapshotId) { | ||
| this.snapshotId = Objects.requireNonNull(snapshotId, "[snapshot_id] must not be null"); | ||
| } |
Member
There was a problem hiding this comment.
I am not sure these setters are necessary, there is only one constructor and it requires both parameters to be set anyways.
…e/add-ml-delete-model-snapshot-to-hlrc
benwtrent
approved these changes
Nov 15, 2018
edsavage
added a commit
that referenced
this pull request
Nov 15, 2018
edsavage
added a commit
to edsavage/elasticsearch
that referenced
this pull request
Nov 19, 2018
edsavage
added a commit
that referenced
this pull request
Nov 20, 2018
edsavage
added a commit
that referenced
this pull request
Nov 20, 2018
98 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #29827