HLRC: Add "_has_privileges" API to Security Client#35479
Merged
tvernum merged 4 commits intoelastic:masterfrom Nov 16, 2018
Merged
HLRC: Add "_has_privileges" API to Security Client#35479tvernum merged 4 commits intoelastic:masterfrom
tvernum merged 4 commits intoelastic:masterfrom
Conversation
This adds the "hasPrivileges()" method to SecurityClient, including request, response & async variant of the method. Also includes API documentation.
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
CC: @elastic/es-security |
98 tasks
albertzaharovits
approved these changes
Nov 14, 2018
Contributor
albertzaharovits
left a comment
There was a problem hiding this comment.
LGTM ❤️
I would've used AbstractHlrcStreamableXContentTestCase for HasPrivilegesResponseTests . It's easier to write and more valuable as it tests the serialization against the server entity. And maybe added AbstractHlrcStreamableXContentTestCase. We also should reserve some time, when all APIs are done, to write tests in SecurityIT.
...t/rest-high-level/src/main/java/org/elasticsearch/client/security/HasPrivilegesResponse.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Scrap that, I worked it out. |
Contributor
Author
|
@albertzaharovits I'm going to raise the |
tvernum
added a commit
that referenced
this pull request
Nov 20, 2018
This adds the "hasPrivileges()" method to SecurityClient, including request, response & async variant of the method. Also includes API documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the "hasPrivileges()" method to SecurityClient, including
request, response & async variant of the method.
Also includes API documentation.
Relates: #29827