[HLRC] Added support for CCR Put Follow API#35409
Merged
martijnvg merged 3 commits intoelastic:masterfrom Nov 13, 2018
Merged
Conversation
This change also adds documentation for the Put Follow API and adds a CCR HLRC integration test.
Collaborator
|
Pinging @elastic/es-core-infra |
hub-cap
approved these changes
Nov 12, 2018
Contributor
hub-cap
left a comment
There was a problem hiding this comment.
one small change in the constructor and its good to go.
| private TimeValue readPollTimeout; | ||
|
|
||
| @Override | ||
| public Optional<ValidationException> validate() { |
Contributor
There was a problem hiding this comment.
lets turn this into a constructor that takes these 3 values and make them final in the class. Then you can just remove all of the extra validation stuff and the addValidationError below.
martijnvg
added a commit
that referenced
this pull request
Nov 13, 2018
This change also adds documentation for the Put Follow API and adds a CCR HLRC integration test.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change also adds documentation for the Put Follow API and
adds a CCR HLRC integration test.