Move compression config to ConnectionProfile#35357
Move compression config to ConnectionProfile#35357Tim-Brooks merged 10 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/es-distributed |
|
I want to make sure (in particular) that everyone agrees with this:
This is because we do not really have a great to correlated incoming connections with settings based on cluster alias. Second, I wanted to make sure everyone agrees that Additionally, it feels like |
s1monw
left a comment
There was a problem hiding this comment.
change LGTM. I want to clarify one thing, if we set transport.tcp.compress to true we compress all traffic in the local cluster. yet if we set it to false on a specific remote cluster we would not compress traffic to that cluster, correct?
I agree with this, lets do this in a separate change. we should get rid of the tcp part in all the places IMO. |
|
@tbrooks8 Sharing the comment that I shared with you in another channel last night.
I agree. |
We will not compress requests to that cluster. If |
This is a follow up to elastic#35357. That commit failed to register the new cluster.remote.cluster_name.transport.compress setting with `ClusterSettings`. This commit fixes that.
This is a follow up to #35357. That commit failed to register the new cluster.remote.cluster_name.transport.compress setting with `ClusterSettings`. This commit fixes that.
This is a follow up to #35357. That commit failed to register the new cluster.remote.cluster_name.transport.compress setting with `ClusterSettings`. This commit fixes that.
This is related to #34483. It introduces a namespaced setting for
compression that allows users to configure compression on a per remote
cluster basis. The
transport.tcp.compressremains as a fallbacksetting. If
transport.tcp.compressis set to true, then all requestsand responses are compressed. If it is set to false, only requests to
clusters based on the
cluster.remote.cluster_name.transport.compresssetting are compressed. However, after this change regardless of any
local settings, responses will be compressed if the request that is
received was compressed.