Add a java level freeze/unfreeze API#35353
Merged
s1monw merged 12 commits intoelastic:masterfrom Nov 10, 2018
Merged
Conversation
This change adds a high level freeze API that allows to open an index frozen and vice versa. Indices must be closed in order to become frozen and an open but frozen index must be closed to be defrosted. This change also adds a `index.frozen` setting to mark frozen indices and integrates the frozen engine with the `SearchOperationListener` that resets and releases the directory reader after and before search phases. Relates to elastic#34352 Depends on elastic#34357
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
@bleskes I pushed changes to split out the open part of the freezing |
tlrx
reviewed
Nov 8, 2018
Member
tlrx
left a comment
There was a problem hiding this comment.
Looks very simple - I left some minor comments
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/test/java/org/elasticsearch/index/engine/FrozenIndexTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/test/java/org/elasticsearch/index/engine/FrozenIndexTests.java
Show resolved
Hide resolved
Contributor
Author
|
@tlrx I pushed changes |
bleskes
approved these changes
Nov 9, 2018
Contributor
bleskes
left a comment
There was a problem hiding this comment.
LGTM. Left one comment about the handling of index blocks.
x-pack/plugin/core/src/main/java/org/elasticsearch/index/engine/FrozenEngine.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/test/java/org/elasticsearch/index/engine/FrozenIndexTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/test/java/org/elasticsearch/index/engine/FrozenIndexTests.java
Outdated
Show resolved
Hide resolved
tlrx
approved these changes
Nov 9, 2018
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
s1monw
added a commit
that referenced
this pull request
Nov 10, 2018
This change adds a high level freeze API that allows to mark an index as frozen and vice versa. Indices must be closed in order to become frozen and an open but frozen index must be closed to be defrosted. This change also adds a index.frozen setting to mark frozen indices and integrates the frozen engine with the SearchOperationListener that resets and releases the directory reader after and before search phases. Relates to #34352 Depends on #34357
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a high level freeze API that allows to mark an
index as frozen and vice versa. Indices must be closed in order to
become frozen and an open but frozen index must be closed to be
defrosted. This change also adds a
index.frozensetting tomark frozen indices and integrates the frozen engine with the
SearchOperationListenerthat resets and releases the directoryreader after and before search phases.
Relates to #34352
Depends on #34357