Add documentation for JSON fields.#35281
Conversation
|
Pinging @elastic/es-search-aggs |
d4184d2 to
1d79ad2
Compare
colings86
left a comment
There was a problem hiding this comment.
I left a couple of comments. Thanks for writing this up, its really useful to have documentation early on
There was a problem hiding this comment.
I think it would be useful to explain a bit more about the trade offs of using this vs explicitly mapping the object. For example one advantage of this is that we expect the resulting index to be smaller with the disadvantage of limited query support and no support for aggregations and sorting.
There was a problem hiding this comment.
Makes a lot of sense, I'll expand this section.
There was a problem hiding this comment.
Maybe we should just state that the default is to not skip values of any length rather than mentioning the explicit value here?
There was a problem hiding this comment.
Will fix, I copied this over from the keyword documentation but reading it over again it is quite strange!
e4ee31c to
2ffb459
Compare
1d79ad2 to
27fd00e
Compare
|
@colings86 I think this is ready for another look. |
27fd00e to
87b8ce5
Compare
colings86
left a comment
There was a problem hiding this comment.
LGTM but could you make sure all lines are wrapped to 80 characters before merging?
There was a problem hiding this comment.
It might be better to mark this // TESTSETUP then you don't need to mark the others // TEST[continued].
|
@elasticmachine run sample packaging tests |
|
@elasticmachine run gradle build tests |
e7613b7 to
4c46b07
Compare
After writing tests for all the query types, I noticed these positional queries will actually not work.
d94bf2a to
03e0008
Compare
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
* Add documentation for JSON fields.
No description provided.